New issue
Advanced search Search tips

Issue 649051 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: NA
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: ----

Blocking:
issue 381840



Sign in to add a comment

Implement a finch experiment for compositing opaque scroller

Project Member Reported by schenney@chromium.org, Sep 21 2016

Issue description

Version: 55+
OS: All

Having a finch experiment in place will provide us with data for evaluating the performance win (or loss?) for compositing opaque scrolling content.

See https://bugs.chromium.org/p/chromium/issues/detail?id=381840 for the primary feature implementation bug.

 
Cc: flackr@chromium.org chrishtr@chromium.org wangxianzhu@chromium.org
Blocking: 381840
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef06887f125941e96ab19fba834d9027d36d4c88

commit ef06887f125941e96ab19fba834d9027d36d4c88
Author: schenney <schenney@chromium.org>
Date: Mon Sep 26 19:15:31 2016

Enable compositing of scrolling content on low-DPI when LCD text will be maintained

The RuntimeEnabledFeature is set to on for stable, with switches added to
enable a finch reverse experiment that disables the feature. We should thus
be able to determine the performance impact of this change.

R=chrishtr@chromium.org,kinuko@chromium.org
BUG= 649051 

Review-Url: https://codereview.chromium.org/2358203002
Cr-Commit-Position: refs/heads/master@{#420955}

[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/content/child/runtime_features.cc
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/content/public/common/content_features.cc
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/content/public/common/content_features.h
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/fast/block/child-with-auto-margin-rtl-body-expected.html
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/paint/invalidation/flexbox/scrollbars-changed-expected.txt
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.txt
[add] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/android/fast/overflow/overflow-float-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/linux/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/007-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-float-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/007-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/deprecated-flexbox/009-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/deprecated-flexbox/009-horizontal-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/003-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/007-expected.png
[add] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-float-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-rtl-vertical-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-with-local-background-attachment-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/deprecated-flexbox/009-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/deprecated-flexbox/009-horizontal-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/003-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/007-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-float-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-rtl-vertical-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/repaint-composited-child-in-scrolled-container-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/overflow/007-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-float-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-rtl-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-rtl-vertical-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-stacking-expected.png
[modify] https://crrev.com/ef06887f125941e96ab19fba834d9027d36d4c88/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Labels: -Type-Bug Type-Launch
Labels: -Type-Launch Type-Launch-OWP
Labels: -Type-Launch-OWP Type-Launch
Labels: -Type-Launch Launch-Accessibility-NotReviewed Launch-Legal-NotReviewed Launch-Privacy-NotReviewed Launch-Security-NotReviewed Launch-Test-NotReviewed Launch-UI-NotReviewed Type-Bug
Labels: -Launch-Privacy-NotReviewed -Launch-UI-NotReviewed -Launch-Security-NotReviewed -Launch-Legal-NotReviewed -Launch-Test-NotReviewed -Launch-Accessibility-NotReviewed Launch-Accessibility-NA Launch-Legal-NA Launch-Privacy-NA Launch-Security-NA Launch-Test-NA Launch-UI-NA
Labels: -Type-Bug Type-Launch-OWP
Labels: Launch-Status-Approval-Requested
Status: Fixed (was: Started)
The experiment has come and gone. Results showed a reduction in paint time, as one would hope.

Sign in to add a comment