[privacy] add specific learn more link for "Use a remote service for spelling" |
||||||||||
Issue description> features: what does it do? why do we need it? [x] Use a remote service for spelling checkbox to show better red underlines > bugs: repro steps (I did X and expected Y but Z happened!) click the "Use a remove service checkbox" in the old options UI (chrome://settings), you should see a dialog warning you about Stuff. there's no dialog in new (MD) settings. bummer.
,
Sep 21 2016
It might also be worth thinking about what we want to do with the native modal dialog that is shown if you opt-in to red-underline spellcheck via the context menu on a misspelled word (attached). Could we maintain just one UI for confirmation instead of two?
,
Sep 30 2016
I asked Alan about changing this from a dialog to a two line row: I think the old behavior is really weird. It's a checkbox that pops up a dialog after checking it and the dialog has both checkbox options. How about if we make it a two line toggle row and tell the user in the subtext that it will send what they type to google up-front? (I've attached a screenshot of it). Alan has approved changing to a two line row with a toggle button.
,
Sep 30 2016
sgtm
,
Oct 3 2016
Behaviorally that sounds like a nice simplification. Though if we're going to change the behavior and strings, I'd want the legal and privacy crews to weigh in first. (and I'd like to find a way to remove the word "servers" since that's tech jargon)
,
Oct 6 2016
,
Oct 7 2016
#5, I believe we are good with using the two-line row - and removing the word "servers". tbuckley@, dbeam@ and ainslie@ should have the email about it.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/586eee275624cb36ff14109236c8be3928dab2a6 commit 586eee275624cb36ff14109236c8be3928dab2a6 Author: dschuyler <dschuyler@chromium.org> Date: Mon Oct 10 22:08:23 2016 [MD settings] inform users that the spelling service sends data to google This CL changes the 'use web service for spell checking' checkbox into a two line toggle button row, with a second line describing how typed data will be sent to Google servers. BUG=649050 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2405653002 Cr-Commit-Position: refs/heads/master@{#424258} [modify] https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6/chrome/app/settings_strings.grdp [modify] https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Oct 10 2016
,
Dec 14 2016
,
Dec 14 2016
Does removing the "Learn more" link have any privacy implications?
,
Dec 14 2016
The learn more goes to a generic page covering various topics*. The part that refers to spelling says, "Use a web service to help resolve spelling errors: Use the same spell-checking technology in Chrome as Google Search. Chrome sends the text you typed to Google's servers". That doesn't appear substantially different from the secondary line. WDYT? * https://support.google.com/chrome/answer/114836?visit_id=1-636173360964142410-49043562&p=settings_privacy&rd=1
,
Dec 14 2016
1) That message is already used when you enable spellcheck from the context menu - let's not have two separate messages. Can we share text between dialog and here? 2) Re c#5, we should probably provide that previous context to legal/privacy as well. 3) If you want to know if something has privacy implications, I'd strongly suggest asking privacy people. In general, *any* change in this dialog should see privacy/legal review before launching. Yes, separately from all-of-settings. I'm reopening because I'd like to see these points addressed.
,
Jan 4 2017
More information on the no-dialog implementation. At the top of the page there is a line about "[...] may use web services [...]" where the web services part is a link to the Learn More link in the prior dialog.
,
Jan 4 2017
,
Jan 4 2017
,
Jan 7 2017
,
Mar 16 2017
so tbuckley@ and I discussed this with privacy reviewers (yitingc@, msrarek@) and rehashed all the same points: * having the secondary text explain what's going on seemed sufficient, compared with opening a dialog when toggling a control (a little odd). * the previous learn more link was generic, a preferred (more specific) one could be [1] but that's not linked to by the old UI but would be a nice enhancement. [1] https://www.google.com/chrome/browser/privacy/whitepaper.html#spelling I'm unblocking beta bug as this is now basically an enhancement.
,
Mar 16 2017
msramek@** (sorry!)
,
Apr 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dbeam@chromium.org
, Sep 21 201624.8 KB
24.8 KB View Download