New issue
Advanced search Search tips

Issue 649024 link

Starred by 3 users
Status: Assigned
Owner:
nzolghadr@chromium.org
Cc:
nzolghadr@chromium.org
pucchakayala@chromium.org
dtapu...@chromium.org
mustaq@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use new Enumeration Cases for Mac's NSEvent type and subtype

Project Member Reported by lanwei@chromium.org, Sep 21 2016 
NSEventType's old constants, such as NSMouseMoved... are deprecated in macOS 10.0–10.12, and they need to be replaced by the new enumeration case, such as NSEventTypeMouseMoved...
https://developer.apple.com/reference/appkit/nseventtype?language=objc

Comment 1 by mustaq@chromium.org, Sep 21 2016

Cc: dtapu...@chromium.org
Status: Assigned (was: Available)
As discussed: please try to eval the risk here...
- Which input events will break? Only mouse & stylus? Looks like keyboard is up-to-date?
- What fraction of Mac users are likely to upgrade?

On the fixing side:
- Any chance we will need to make web_input_event_builders_mac.mm OS-version specific for users who may never upgrade?

Comment 2 by dtapu...@chromium.org, Sep 21 2016

Cc: ccameron@chromium.org
ccameron@ do you have any context here being a OSX expert?

Comment 3 by lanwei@chromium.org, Sep 21 2016

Cc: pucchakayala@chromium.org
+ pucchakayala@ from the QA team, she tested last week.

Comment 4 by lanwei@chromium.org, Sep 22 2016

Labels: -Pri-2 Pri-3
pucchakayala@ helped us test on OS 10.12, everything works fine, but not sure about stylus input. It is not high priority and I will update it later.

Comment 5 by dtapu...@chromium.org, Dec 14 2017

Owner: dtapu...@chromium.org
Q4 2017 Still an issue should be a relatively easily sed.

Comment 6 by dtapu...@chromium.org, Aug 31

Owner: nzolghadr@chromium.org
►

Sign in to add a comment