New issue
Advanced search Search tips

Issue 649016 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[It2Me][Host] Remove It2MeConfirmationDialogFactory

Project Member Reported by joedow@chromium.org, Sep 21 2016

Issue description

Per comment in CR, we should be able to remove It2MeConfirmationDialogFactory and just pass a Dialog instance into the It2MeHost C'tor.

 

Comment 1 by joedow@chromium.org, Sep 23 2016

Summary: [It2Me][Host] Remove It2MeConfirmationDialogFactory (was: [It2Me][Host] Remote It2MeConfirmationDialogFactory)

Comment 2 by joedow@chromium.org, Sep 26 2016

Status: Started (was: Assigned)

Comment 3 by joedow@chromium.org, Sep 27 2016

Status: Verified (was: Started)

Comment 4 by joedow@chromium.org, Sep 27 2016

Fix was checked in but it looks like the auto-updater hasn't run.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fcc469912720fdcbc26429b850666778a4ccbb7

commit 7fcc469912720fdcbc26429b850666778a4ccbb7
Author: joedow <joedow@chromium.org>
Date: Tue Sep 27 21:01:10 2016

Removing It2MeConfirmationDialogFactory

Since the It2MeConfirmationDialog is now supported on all platforms, we can
remove the factory used to create dialog instances and instead use a static
method on the class itself.

BUG= 649016 

Review-Url: https://codereview.chromium.org/2372833002
Cr-Commit-Position: refs/heads/master@{#421333}

[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/BUILD.gn
[delete] https://crrev.com/5fc08cfb098acce49344d2e89cc27c915903f81c/remoting/host/it2me/it2me_confirmation_dialog.cc
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_confirmation_dialog.h
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_confirmation_dialog_chromeos.cc
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_confirmation_dialog_linux.cc
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_confirmation_dialog_mac.mm
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_confirmation_dialog_win.cc
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_host.cc
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_host.h
[modify] https://crrev.com/7fcc469912720fdcbc26429b850666778a4ccbb7/remoting/host/it2me/it2me_host_unittest.cc

Sign in to add a comment