Harmony - pressing Escape with textfield selection beeps then dismisses cookie dialog |
||
Issue descriptionVersion: 55.0.2867.0 OS: 10.12 What steps will reproduce the problem? (1) In a new tab perform a Google search (2) Click lock icon (3) Click cookies link in OIB (4) Expand google.com in table (5) Expand Cookies in table (6) Expand NID in the table (7) Select a portion of the Content textfield data (8) Press Escape What is the expected output? The dialog should be dismissed silently. What do you see instead? I hear a beep, and then the dialog dismisses. I think a non-editable textfield should forward / ignore the Return, Enter, and Escape, allowing something up higher in the dialog to handle it (and possibly beep). Please use labels and text to provide additional information.
,
Oct 6 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48a12e434146dc568dabb364d84be911b6d369e4 commit 48a12e434146dc568dabb364d84be911b6d369e4 Author: ellyjones <ellyjones@chromium.org> Date: Fri Oct 07 18:00:08 2016 views: don't send OnKeypressUnhandled for all keys Textfield::OnKeyPressed() is not responsible for all keystroke handling, but it is called for every pressed key, which means that 'handled' in this function is not correct if the key is handled elsewhere, like IME or focus hotkeys. As such, don't call OnKeypressUnhandled() in OnKeyPressed() at all; only call it in InsertChar() for readonly textfields. BUG= 649559 , 649007 Review-Url: https://codereview.chromium.org/2399603002 Cr-Commit-Position: refs/heads/master@{#423908} [modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style.cc [modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style.h [modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style_mac.mm
,
Oct 10 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by shrike@chromium.org
, Oct 1 2016