New issue
Advanced search Search tips

Issue 649003 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Harmony - cookies dialog folder item has different icons when selected, not selected

Project Member Reported by shrike@chromium.org, Sep 21 2016

Issue description

Version: 55.0.2867.0
OS: 10.12

What steps will reproduce the problem?
(1) In a new tab perform a Google search
(2) Click lock icon
(3) Click cookies link in OIB
(4) Expand google.com in table
(5) Select Cookies in table

What is the expected output?
The Cookies item displays a closed folder icon before and after selecting it

What do you see instead?
The Cookies item displays a closed folder icon before selecting it, and an open folder icon after selecting it

At most the icon should change to an open folder when you expand the item, but we should not make it work that way. The icon should remain a closed folder.

 
Labels: Proj-HarmonyControls
Labels: M-56
Cc: bettes@chromium.org
The bookmark manager, which shares these icons, is weird too -- it displays a closed folder until the tree item is expanded, at which point it's open (i.e. the way comment 0 says we "should not make this work"), but if you then delete the contents of the higher-level folder, so it auto-closes, the icon gets stuck "open".

Windows native behavior would be to use a single closed folder icon for all these states.  Is there any formal Chrome design policy regarding this, or can we safely just do what it sounds like Win and Mac both want and remove the "open folder" state entirely?

+CC bettes for that.
Cc: -bettes@chromium.org
Labels: -Pri-2 -M-56 Hotlist-Polish Pri-3
Owner: bettes@chromium.org
M-56 clearly didn't happen.  Dropping priority; we can ship phase 1 without fixing this.  That said, it seems like we can just use a closed icon all the time and simplify the code.

->bettes to veto that if necessary.  If he says OK, this goes into the "nice to have" pool and gets marked Available.
Labels: -OS-Mac
(It sounds like https://codereview.chromium.org/2772613003 may have fixed this on Mac, optimistically unmarking there)

Comment 6 by bettes@chromium.org, Jan 11 2018

Owner: ----
Status: Available (was: Assigned)
The expected output in c1 SGTM. Thanks!
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment