Merging a CL about language identification into M54 |
||||||
Issue descriptionWe'd like to merge the following CL into M54: https://codereview.chromium.org/2359793003/ The CL modifies language detection code, so that if CLD3 predicts a transliterated language that is currently not supported, then the prediction is ignored. Unlike CLD2, CLD3 identifies the following transliterated languages bg-Latn, el-Latn, hi-Latn, ja-Latn, ru-Latn, zh-Latn. The CL mentioned above modifies code in language_detection_util.cc, so that if the model predicts "xx-Latn" for xx != "hi", then the adopted language is set to the default one ("unknown") which results in Translate not triggering. We do this because if the language prediction is "xx-Latn", Chrome removes the "-Latn" suffix and the adopted language is "xx". This procedure works fine for Hindi ("hi") but the remaining transliterated languages are currently not supported. The CL also modifies i18n_custom_bindings.cc to ignore xx-Latn predictions (1) because no client is currently using them, (2) to maintain backwards compatibility.
,
Sep 27 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52247dcede791eae0c75996335a9b2bb0d9df236 commit 52247dcede791eae0c75996335a9b2bb0d9df236 Author: abakalov <abakalov@chromium.org> Date: Wed Sep 28 05:07:16 2016 Modifying language detection code If the language detection model CLD3 predicts a transliterated language that is currently not supported, then the prediction is ignored. For more information, please see the bug entry below. BUG= 649002 Review-Url: https://codereview.chromium.org/2359793003 Cr-Commit-Position: refs/heads/master@{#421451} [modify] https://crrev.com/52247dcede791eae0c75996335a9b2bb0d9df236/components/translate/core/language_detection/language_detection_util.cc [modify] https://crrev.com/52247dcede791eae0c75996335a9b2bb0d9df236/extensions/renderer/i18n_custom_bindings.cc
,
Sep 29 2016
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4d4c425350471ad689078bb50f637531839e13e commit f4d4c425350471ad689078bb50f637531839e13e Author: Rachel Blum <groby@google.com> Date: Fri Sep 30 02:07:43 2016 Modifying language detection code If the language detection model CLD3 predicts a transliterated language that is currently not supported, then the prediction is ignored. For more information, please see the bug entry below. BUG= 649002 Review-Url: https://codereview.chromium.org/2359793003 Cr-Commit-Position: refs/heads/master@{#421451} (cherry picked from commit 52247dcede791eae0c75996335a9b2bb0d9df236) Review URL: https://codereview.chromium.org/2385573002 . Cr-Commit-Position: refs/branch-heads/2840@{#594} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f4d4c425350471ad689078bb50f637531839e13e/components/translate/core/language_detection/language_detection_util.cc [modify] https://crrev.com/f4d4c425350471ad689078bb50f637531839e13e/extensions/renderer/i18n_custom_bindings.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4d4c425350471ad689078bb50f637531839e13e commit f4d4c425350471ad689078bb50f637531839e13e Author: Rachel Blum <groby@google.com> Date: Fri Sep 30 02:07:43 2016 Modifying language detection code If the language detection model CLD3 predicts a transliterated language that is currently not supported, then the prediction is ignored. For more information, please see the bug entry below. BUG= 649002 Review-Url: https://codereview.chromium.org/2359793003 Cr-Commit-Position: refs/heads/master@{#421451} (cherry picked from commit 52247dcede791eae0c75996335a9b2bb0d9df236) Review URL: https://codereview.chromium.org/2385573002 . Cr-Commit-Position: refs/branch-heads/2840@{#594} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f4d4c425350471ad689078bb50f637531839e13e/components/translate/core/language_detection/language_detection_util.cc [modify] https://crrev.com/f4d4c425350471ad689078bb50f637531839e13e/extensions/renderer/i18n_custom_bindings.cc
,
Dec 1 2016
This appears to have been done based on #6, marking as fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by abakalov@chromium.org
, Sep 21 2016