New issue
Advanced search Search tips

Issue 649001 link

Starred by 2 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Oct 2016
Cc:
jawag@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Startup pages overridden bubble shows on chrome://restart

Project Member Reported by rdevlin....@chromium.org, Sep 21 2016 
What steps will reproduce the problem?
1. Install an extension that overrides startup pages
2. Restart chrome (e.g. go to chrome://restart)

What is the expected result?
The warning around an extension overriding your startup pages shouldn't show (or, potentially, it should show and we should show those startup pages).

What happens instead of that?
The warning around an extension overriding your startup pages does show.

When chrome is restarted, we always do a session restore, i.e., we open up the same tabs you had open when you restarted chrome.  However, the startup pages bubble shows on first startup after the extension is installed.  This doesn't make sense in the case of a restart, since it will say "Are these the startup pages you were expecting?" while displaying the pages the user previously had open.

Instead, we should only show the startup pages bubble if chrome wasn't restarted.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9a05aa24453233fa8cd375a5d9fff11de8a7c32

commit d9a05aa24453233fa8cd375a5d9fff11de8a7c32
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Sep 21 18:41:38 2016

[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG= 649001 

Review-Url: https://codereview.chromium.org/2350733005
Cr-Commit-Position: refs/heads/master@{#420115}

[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/extensions/extension_browsertest.h
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/extensions/extension_message_bubble_browsertest.h
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/extensions/extension_message_bubble_factory.cc
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.h
[modify] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
[add] https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32/chrome/test/data/extensions/startup_pages/manifest.json

Comment 2 by rdevlin....@chromium.org, Oct 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment