New issue
Advanced search Search tips

Issue 648997 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.7%-7.9% improvement in webrtc_perf_tests at 14283:14283

Project Member Reported by terelius@chromium.org, Sep 21 2016

Issue description

Using I420Buffer to write pixel data appears to improve the encode time in some tests. Well done!

Please verify that the improvements look reasonable.
 

Comment 2 by nisse@chromium.org, Sep 22 2016

Status: WontFix (was: Assigned)
The cl (https://codereview.webrtc.org/2347863002/) replaces some calls to ConvertToI420 to I420Copy, on the path reading YUV-frames from file. Which *might* be more efficient. But ConvertToI420 should boil down to I420Copy after a few levels of function calls, so 5% to 8% improvement is unexpectedly much.

Actually, the copying involved here is useless, I'm considering another cl to read the data with fread directly to the right location.

Closing, since it is an improvement.

Sign in to add a comment