Whitelist Ricoh print extension for Chrome in Public Sessions |
|||||||||||
Issue descriptionPlease evaluate and whitelist Ricoh print extension for Chrome. Ideally we would like it to be white-listed for M-54 https://chrome.google.com/webstore/detail/ricoh-print-for-chrome/ioofdkhojeeimmagbjbknkejkgbphdfl It is an extension that allows users to print from Chrome by specifying target printer’s network IP address. The target printer does not have to be Google Cloud Print ready. It requests the following permissions - {u'socket': [u'tcp-listen:*:*', u'tcp-connect', u'resolve-host', u'udp-bind:*:*', u'udp-send-to:*:*']} storage printerProvider unlimitedStorage mdns Similar bug for HP print extension (just for reference) - https://bugs.chromium.org/p/chromium/issues/detail?id=526770
,
Sep 22 2016
,
Sep 23 2016
Looking...
,
Sep 23 2016
I've looked at the manifest, features/permissions look good. In fact, the only permission it's requesting that we're not already whitelisting is printerProvider. I haven't reviewed the extension JS code, but since this app doesn't is fairly limited in permission it requests, it should be fine. Bottom line: Approved for whitelisting. Side note: Please add a TODO to the code though to have this app removed from the manual whitelist once the undergoing work to expand the automatic whitelisting (i.e. allowing printerProvider) has landed. Bonus points for creating a bug entry as a blocker for issue 633301 so we don't forget :) Assigning back to Raj for further routing.
,
Sep 23 2016
Thanks Mattias. bartfab@ - Please whitelist the extension I have created bug crbug.com/649772 to review all the whitelisted apps/extensions for PS once we expand automatic whitelisting for PS
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5320f2e11641641470ee87a1b7c1cd83f3c8ca7 commit d5320f2e11641641470ee87a1b7c1cd83f3c8ca7 Author: bartfab <bartfab@chromium.org> Date: Wed Sep 28 12:47:42 2016 Whitelist Ricoh print extension for user in Public Sessions This CL allows the RICOH Print for Chrome extension to run in Public Sessions. BUG= 648993 TEST=None Review-Url: https://codereview.chromium.org/2373553002 Cr-Commit-Position: refs/heads/master@{#421503} [modify] https://crrev.com/d5320f2e11641641470ee87a1b7c1cd83f3c8ca7/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Sep 29 2016
,
Oct 4 2016
Verified that the works on R55(8860.0.0 55.0.2878.0. ) Verified that the Ricoh print extension for Chrome is whitelisted for ChromeOS Public Sessions ie(Ricoh print extension can be force installed via policy and is installed on the chrome device) . Requesting Merge to R54.
,
Oct 4 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 5 2016
,
Oct 9 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd853d275f8ec876331d830075714b468b198fc8 commit fd853d275f8ec876331d830075714b468b198fc8 Author: Bartosz Fabianowski <bartfab@chromium.org> Date: Tue Oct 11 09:50:37 2016 Whitelist Ricoh print extension for user in Public Sessions This CL allows the RICOH Print for Chrome extension to run in Public Sessions. BUG= 648993 TEST=None Review-Url: https://codereview.chromium.org/2373553002 Cr-Commit-Position: refs/heads/master@{#421503} (cherry picked from commit d5320f2e11641641470ee87a1b7c1cd83f3c8ca7) Review URL: https://codereview.chromium.org/2407193002 . Cr-Commit-Position: refs/branch-heads/2840@{#713} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fd853d275f8ec876331d830075714b468b198fc8/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Oct 13 2016
Pit M ChromeOS Chrome ARC Type Channel 54 8743.65.0 54.0.2840.59 3344292 release beta
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd853d275f8ec876331d830075714b468b198fc8 commit fd853d275f8ec876331d830075714b468b198fc8 Author: Bartosz Fabianowski <bartfab@chromium.org> Date: Tue Oct 11 09:50:37 2016 Whitelist Ricoh print extension for user in Public Sessions This CL allows the RICOH Print for Chrome extension to run in Public Sessions. BUG= 648993 TEST=None Review-Url: https://codereview.chromium.org/2373553002 Cr-Commit-Position: refs/heads/master@{#421503} (cherry picked from commit d5320f2e11641641470ee87a1b7c1cd83f3c8ca7) Review URL: https://codereview.chromium.org/2407193002 . Cr-Commit-Position: refs/branch-heads/2840@{#713} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fd853d275f8ec876331d830075714b468b198fc8/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jsc...@chromium.org
, Sep 21 2016Owner: mnissler@chromium.org