New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648986 link

Starred by 3 users
Status: Duplicate
Merged: issue 410785
Owner:
changwan@chromium.org
Closed: Oct 2016
Cc:
█ yabinh@chromium.org
█ aelias@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Input does not have "Go" button if its type is number

Reported by karlsson...@gmail.com, Sep 21 2016 
Device name: Nexus 5X

Application version: Chrome 53.0.2785.124
OS: Android 7.0.0; Nexus 5X Build/NRD90S

URLs (if applicable): https://jsfiddle.net/rkcvzjos/

Behavior in Android Browser (if applicable):
When the last HTML input it a page is of the type number the keyboard will show "next input" (tab behaviour) instead of "GO" to submit the form.


Steps to reproduce:
(1) Create an input of type number as last input on page
(2) Enter anything
(3) Press enter

Expected result:
To submit the form. (as done with type="text")

Actual result:
Focus gets moved to the search-bar in chrome.

Comment 1 by dtapu...@chromium.org, Sep 22 2016

Components: Blink>Forms

Comment 2 by tkent@chromium.org, Sep 23 2016

Cc: aurimas@chromium.org changwan@chromium.org
Components: -Blink>Forms IO>Keyboard Blink>Forms>Number
Labels: Type-Bug
Status: Available (was: Unconfirmed)
Summary: Input does not have "Go" button if its type is number (was: Input does not submit if type number)
Yeah, type=number and type=tel don't have EditorInfo.IME_ACTION_GO flag.

https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java?l=83

Comment 3 by aurimas@chromium.org, Sep 23 2016

Cc: -aurimas@chromium.org
I do not work on Chrome anymore.

Comment 4 by changwan@chromium.org, Sep 23 2016

Cc: aelias@chromium.org yabinh@chromium.org
Components: -IO>Keyboard UI>Input>Text>IME
Owner: changwan@chromium.org
The current logic of deciding on IME action is a pure guess: it sometimes adds EditorInfo.IME_ACTION_NEXT and it sometimes adds IME_ACTION_GO solely based on the input type not based on a real requirement of the website.

If IME_ACTION_NEXT is incorrectly set, ImeAdapter emits a tab key event which may move the focus to the omnibox and that's happening here.

We should instead try to check
1) whether the current input form is last in tab index or not within a form if any (if it is it should be IME_ACTION_NEXT)
2) whether there is an actionable form target (if there isn't it should be IME_ACTION_NONE)

Comment 5 by aelias@chromium.org, Sep 23 2016

Status: Assigned (was: Available)
Sounds like a good plan.

Comment 6 by changwan@chromium.org, Oct 3 2016

Mergedinto: 410785
Status: Duplicate (was: Assigned)
Actually this is a dup of the long-standing  issue 410785 . Let me merge it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d80ad1410dcb23f55c323a97e57eed750a611dc

commit 8d80ad1410dcb23f55c323a97e57eed750a611dc
Author: ajith.v <ajith.v@samsung.com>
Date: Tue Jun 13 20:21:13 2017

[Android] Adding Smart GO/NEXT feature in Chrome

Smart Go/Next brings better user experience to the user during form submitting applications.
For navigating between form elements, user can use NEXT/PREVIOUS button from IME
without touching on individual fields. This will avoid unnecessary form submissions before
filling or visiting all fields in the form.

Additionally it will save user time and avoid redundant network requests before actually
filling/attending entire fields in the form

Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing

BUG= 410785 , 648986 

Review-Url: https://codereview.chromium.org/2839993002
Cr-Commit-Position: refs/heads/master@{#479126}

[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/common/frame_messages.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/renderer/render_frame_impl.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/content/test/data/android/input/input_forms.html
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[add] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html
[add] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html
[add] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/public/platform/WebFocusType.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/8d80ad1410dcb23f55c323a97e57eed750a611dc/third_party/WebKit/public/web/WebLocalFrame.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76fc114441c30b033be4b3aa74dba49eba5ad072

commit 76fc114441c30b033be4b3aa74dba49eba5ad072
Author: kochi <kochi@chromium.org>
Date: Thu Jun 15 04:25:23 2017

Revert of [Android] Adding Smart GO/NEXT feature in Chrome (patchset #26 id:500001 of https://codereview.chromium.org/2839993002/ )

Reason for revert:
This caused several clusterfuzz bugs
(733197, 733218, 733282) - let me revert for
investigation on those.

Original issue's description:
> [Android] Adding Smart GO/NEXT feature in Chrome
>
> Smart Go/Next brings better user experience to the user during form submitting applications.
> For navigating between form elements, user can use NEXT/PREVIOUS button from IME
> without touching on individual fields. This will avoid unnecessary form submissions before
> filling or visiting all fields in the form.
>
> Additionally it will save user time and avoid redundant network requests before actually
> filling/attending entire fields in the form
>
> Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing
>
> BUG= 410785 , 648986 
>
> Review-Url: https://codereview.chromium.org/2839993002
> Cr-Commit-Position: refs/heads/master@{#479126}
> Committed: https://chromium.googlesource.com/chromium/src/+/8d80ad1410dcb23f55c323a97e57eed750a611dc

TBR=tkent@chromium.org,changwan@chromium.org,dcheng@chromium.org,ekaramad@chromium.org,nasko@chromium.org,yosin@chromium.org,aelias@chromium.org,ajith.v@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 410785 , 648986 

Review-Url: https://codereview.chromium.org/2938123002
Cr-Commit-Position: refs/heads/master@{#479601}

[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/common/frame_messages.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/renderer/render_frame_impl.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/content/test/data/android/input/input_forms.html
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[delete] https://crrev.com/05cb777e577c0a2b47f6b0ce552a1198d54e6478/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html
[delete] https://crrev.com/05cb777e577c0a2b47f6b0ce552a1198d54e6478/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html
[delete] https://crrev.com/05cb777e577c0a2b47f6b0ce552a1198d54e6478/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/public/platform/WebFocusType.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/76fc114441c30b033be4b3aa74dba49eba5ad072/third_party/WebKit/public/web/WebLocalFrame.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eb6812cc312e4ea919518a4e3087944e31b3b72

commit 4eb6812cc312e4ea919518a4e3087944e31b3b72
Author: ajith.v <ajith.v@samsung.com>
Date: Fri Jun 23 13:38:16 2017

Relanding [Android] Adding Smart GO/NEXT feature in Chrome

Smart Go/Next brings better user experience to the user during form submitting applications.
For navigating between form elements, user can use NEXT/PREVIOUS button from IME
without touching on individual fields. This will avoid unnecessary form submissions before
filling or visiting all fields in the form.

Additionally it will save user time and avoid redundant network requests before actually
filling/attending entire fields in the form

Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing

Initial patch is reviewed @ https://codereview.chromium.org/2839993002/

BUG= 410785 , 648986 ,  733222 

Review-Url: https://codereview.chromium.org/2948593002
Cr-Commit-Position: refs/heads/master@{#481868}

[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/common/frame_messages.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/renderer/render_frame_impl.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/content/test/data/android/input/input_forms.html
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[add] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html
[add] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html
[add] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/public/platform/WebFocusType.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/4eb6812cc312e4ea919518a4e3087944e31b3b72/third_party/WebKit/public/web/WebLocalFrame.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa75e2abb23205caa6d7f61edc89e672e83f6089

commit fa75e2abb23205caa6d7f61edc89e672e83f6089
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Jun 28 08:22:13 2017

Revert of Relanding [Android] Adding Smart GO/NEXT feature in Chrome (patchset #4 id:80001 of https://codereview.chromium.org/2948593002/ )

Reason for revert:
This caused perf regression on browse_social_facebook_infinite_scroll
test on most platforms.

See  crbug.com/737388  for details.

Original issue's description:
> Relanding [Android] Adding Smart GO/NEXT feature in Chrome
>
> Smart Go/Next brings better user experience to the user during form submitting applications.
> For navigating between form elements, user can use NEXT/PREVIOUS button from IME
> without touching on individual fields. This will avoid unnecessary form submissions before
> filling or visiting all fields in the form.
>
> Additionally it will save user time and avoid redundant network requests before actually
> filling/attending entire fields in the form
>
> Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing
>
> Initial patch is reviewed @ https://codereview.chromium.org/2839993002/
>
> BUG= 410785 , 648986 ,  733222 
>
> Review-Url: https://codereview.chromium.org/2948593002
> Cr-Commit-Position: refs/heads/master@{#481868}
> Committed: https://chromium.googlesource.com/chromium/src/+/4eb6812cc312e4ea919518a4e3087944e31b3b72

TBR=yosin@chromium.org,aelias@chromium.org,changwan@chromium.org,dcheng@chromium.org,kochi@chromium.org,tedchoc@chromium.org,tkent@chromium.org,yfriedman@chromium.org,nasko@chromium.org,ajith.v@samsung.com
BUG= 410785 , 648986 ,  733222 

patch from issue 2955283002 at patchset 1 (http://crrev.com/2955283002#ps1)

Change-Id: Idd861244a71d079581f7a1a6337c1ebad245ca71
Reviewed-on: https://chromium-review.googlesource.com/551697
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482918}
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/common/frame_messages.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/renderer/render_frame_impl.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/content/test/data/android/input/input_forms.html
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[delete] https://crrev.com/b919d95a7f8be9ca291d6bbff942cfb42d08d5a1/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html
[delete] https://crrev.com/b919d95a7f8be9ca291d6bbff942cfb42d08d5a1/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html
[delete] https://crrev.com/b919d95a7f8be9ca291d6bbff942cfb42d08d5a1/third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/public/platform/WebFocusType.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/fa75e2abb23205caa6d7f61edc89e672e83f6089/third_party/WebKit/public/web/WebLocalFrame.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/933aca75233fbb5145c29c1e5a06e5f36c308cc0

commit 933aca75233fbb5145c29c1e5a06e5f36c308cc0
Author: ajith.v <ajith.v@samsung.com>
Date: Mon Jul 03 17:05:26 2017

Relanding [Android] Adding Smart GO/NEXT feature in Chrome

Smart Go/Next brings better user experience to the user during form submitting applications.
For navigating between form elements, user can use NEXT/PREVIOUS button from IME
without touching on individual fields. This will avoid unnecessary form submissions before
filling or visiting all fields in the form.

Additionally it will save user time and avoid redundant network requests before actually
filling/attending entire fields in the form

Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing

Initial patch is reviewed @ https://codereview.chromium.org/2839993002/ and
https://codereview.chromium.org/2948593002/

Scrolling performance is getting effected due to call to
NextFocusableElementInForm() from InputMethodController. hence splitting it into multiple patches.
This is the initial landing without enabling functionality.
In next patch functionality will be enabled with necessary test coverage.

BUG= 410785 ,  648986 ,  733222 

Review-Url: https://codereview.chromium.org/2967493002
Cr-Commit-Position: refs/heads/master@{#484020}

[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/browser/android/ime_adapter_android.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/common/frame_messages.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/content/renderer/render_frame_impl.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/Source/core/page/FocusController.cpp
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/Source/core/page/FocusController.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/public/platform/WebFocusType.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/public/platform/WebTextInputType.h
[modify] https://crrev.com/933aca75233fbb5145c29c1e5a06e5f36c308cc0/third_party/WebKit/public/web/WebLocalFrame.h
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/041c0b075176fb9bca94fd67fc1b6053a4df2e1c

commit 041c0b075176fb9bca94fd67fc1b6053a4df2e1c
Author: AJITH KUMAR V <ajith.v@samsung.com>
Date: Tue Aug 08 10:39:20 2017

[Android] Relanding Smart GO NEXT feature in Android Chrome 2/2

This is second patch of Smart GO NEXT feature. Initial patch is
landed @ https://codereview.chromium.org/2967493002/

Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing

Performance regression is getting tackled using the triggering of Focus Controller
call only if element focus is changed, otherwise continue to use previously cached value.
This will save unwanted tree traversal in every frame update.

BUG= 410785 ,  648986 ,  733222 ,  737388 

Change-Id: Ib2c7343a6ec7dea18c7cfa5ac283ac4d29e3a4cb
Reviewed-on: https://chromium-review.googlesource.com/574514
Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492588}
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/renderer/render_widget.cc
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/renderer/render_widget.h
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/content/test/data/android/input/input_forms.html
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/editing/InputMethodController.h
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_disabled_and_readonly_elements.html
[add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_key_event_listeners.html
[add] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/Source/core/testing/data/advance_focus_in_form_with_tabindex_elements.html
[modify] https://crrev.com/041c0b075176fb9bca94fd67fc1b6053a4df2e1c/third_party/WebKit/public/web/WebInputMethodController.h
►

Sign in to add a comment