New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648968 link

Starred by 1 user
Status: WontFix
Owner:
kkhorimoto@chromium.org
Closed: Oct 2
Cc:
█ noyau@chromium.org
edchin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 648210



Sign in to add a comment

[clang-static-analyzer] tab_switcher_panel_overlay_view.mm : Null passed to a callee that requires a non-null 2nd parameter

Project Member Reported by sdefresne@chromium.org, Sep 21 2016 
See screenshot for detailed error.

Summary, -updateButtonTarget can invoke -addTarget:action:forControlEvents: with an empty selector if self.overlayType is OVERLAY_PANEL_USER_SIGNED_IN_SYNC_IN_PROGRESS.

jif: can you investigate?
Screen Shot 2016-09-21 at 16.25.04.png
209 KB View Download

Comment 1 by sdefresne@chromium.org, Jan 31 2017

Labels: -Pri-3 Pri-2
I looked at the code and this bug still exists. It is possible to have a nil value for "selector" when calling addTarget:action:forControlEvents: in that method. According to the documentation, passing nil there is forbidden (the method argument is marked as __NonNull).

Comment 2 by sdefresne@chromium.org, Jan 31 2017

Labels: -Restrict-View-Google
Removing R-V-G as the code is now upstream.

Comment 3 by jasonkliu@chromium.org, Apr 7 2017

Labels: Hotlist-Needs-New-Component

Comment 4 by eugene...@chromium.org, May 30 2017

Components: UI>Browser>Mobile>TabSwitcher
Labels: -Hotlist-Needs-New-Component

Comment 5 by eugene...@chromium.org, Jun 19 2018

Owner: ----
Status: Untriaged (was: Assigned)
jif@ is no longer on the team, so these bugs require triage

Comment 6 by kkhorimoto@chromium.org, Jun 28 2018

Owner: kkhorimoto@chromium.org
Status: Started (was: Untriaged)
I looked at the code to see if this still happens, but it's a simple fix so I'll just take this.

Comment 8 by kkhorimoto@chromium.org, Jun 28 2018

Cc: edchin@chromium.org

Comment 9 by marq@chromium.org, Oct 2

Status: WontFix (was: Started)
Closing bugs for older tab switcher UIs.
►

Sign in to add a comment