The logic in MainController's BrowsingDataRemovalControllerDelegate method (removeExternalFilesForBrowserState:completionHandler:) should be moved into the removal controller. (potentially related CL: https://chromereviews.googleplex.com/244197013.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1615562882369a3db6cf889b29cbdadb4a1d21df commit 1615562882369a3db6cf889b29cbdadb4a1d21df Author: sczs <sczs@chromium.org> Date: Wed Sep 13 14:48:57 2017 [ios] Removes BVC dependencies from external_file_remover. This is CL 1 of 2 for removing BrowsingDataRemovalControllerDelegate. Bug: 648940 Change-Id: I18d43e008388138d303ad165a313110d2c3b940c Reviewed-on: https://chromium-review.googlesource.com/654377 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501630} [modify] https://crrev.com/1615562882369a3db6cf889b29cbdadb4a1d21df/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/1615562882369a3db6cf889b29cbdadb4a1d21df/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/1615562882369a3db6cf889b29cbdadb4a1d21df/ios/chrome/browser/ui/external_file_remover.h [modify] https://crrev.com/1615562882369a3db6cf889b29cbdadb4a1d21df/ios/chrome/browser/ui/external_file_remover.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc commit adccb5e77cd7d5c310d02dd18390fcf12b7acfbc Author: sczs <sczs@chromium.org> Date: Fri Sep 15 20:05:42 2017 [ios] Removes BrowsingDataRemovalControllerDelegate Moves ExternalFileRemover from BVC to the Class using it. In order to do this this CL: -Changes ExternalFileRemover to be KeyedService. -Creates a ExternalFileRemoverFactory to vend the ExternalFileRemovers. This is CL 2 of 2 for removing BrowsingDataRemovalControllerDelegate. Bug: 648940 Change-Id: I70aa4fb084f0c0770c7366de360f4604a605fa54 Reviewed-on: https://chromium-review.googlesource.com/666016 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502340} [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/app/main_controller.mm [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/browsing_data/browsing_data_removal_controller.h [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/browsing_data/browsing_data_removal_controller_unittest.mm [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/external_file_remover.h [delete] https://crrev.com/303666dfb2577cadef5c1e29b4c097dbdd41738b/ios/chrome/browser/ui/external_file_remover.mm [add] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/external_file_remover_factory.h [add] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/external_file_remover_factory.mm [add] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/external_file_remover_impl.h [add] https://crrev.com/adccb5e77cd7d5c310d02dd18390fcf12b7acfbc/ios/chrome/browser/ui/external_file_remover_impl.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2d7feedd2066e51ab29d32877b37be6f3d7fb71 commit f2d7feedd2066e51ab29d32877b37be6f3d7fb71 Author: Eugene But <eugenebut@chromium.org> Date: Sat Sep 16 01:27:55 2017 Revert "[ios] Removes BrowsingDataRemovalControllerDelegate" This reverts commit adccb5e77cd7d5c310d02dd18390fcf12b7acfbc. Reason for revert: Breaks downstream External URL Tests: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/7638/steps/ios_internal_chrome_external_url_egtests%20%28iPhone%205%20iOS%2010.0%29%20on%20Mac/logs/stdio Original change's description: > [ios] Removes BrowsingDataRemovalControllerDelegate > > Moves ExternalFileRemover from BVC to the Class using it. In order to > do this this CL: > > -Changes ExternalFileRemover to be KeyedService. > -Creates a ExternalFileRemoverFactory to vend the ExternalFileRemovers. > > This is CL 2 of 2 for removing BrowsingDataRemovalControllerDelegate. > > Bug: 648940 > Change-Id: I70aa4fb084f0c0770c7366de360f4604a605fa54 > Reviewed-on: https://chromium-review.googlesource.com/666016 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502340} TBR=sdefresne@chromium.org,sczs@chromium.org Change-Id: Id7c68093a66214eeb948a614725a1379b6853bbe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 648940 Reviewed-on: https://chromium-review.googlesource.com/669824 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#502463} [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/app/main_controller.mm [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/browsing_data/browsing_data_removal_controller.h [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/browsing_data/browsing_data_removal_controller_unittest.mm [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/ui/external_file_remover.h [add] https://crrev.com/f2d7feedd2066e51ab29d32877b37be6f3d7fb71/ios/chrome/browser/ui/external_file_remover.mm [delete] https://crrev.com/16e7ea72e54a3e88de3d92a1859468740fef0df6/ios/chrome/browser/ui/external_file_remover_factory.h [delete] https://crrev.com/16e7ea72e54a3e88de3d92a1859468740fef0df6/ios/chrome/browser/ui/external_file_remover_factory.mm [delete] https://crrev.com/16e7ea72e54a3e88de3d92a1859468740fef0df6/ios/chrome/browser/ui/external_file_remover_impl.h [delete] https://crrev.com/16e7ea72e54a3e88de3d92a1859468740fef0df6/ios/chrome/browser/ui/external_file_remover_impl.mm
I think this is the most relevant Bug remaining from the IDC commands removal.
Comment 1 by jasonkliu@chromium.org
, Apr 7 2017