PresentationConnectionAvailableEvent is untested |
|||||
Issue description
There are no tests for this in LayoutTests/
Some test should check `event instanceof PresentationConnectionAvailableEvent` for an event fired by the UA, and some test should test the PresentationConnectionAvailableEvent constructor, making sure that e.g. new PresentationConnectionAvailableEvent('type', { connection: null }) throws.
,
Sep 28 2016
Should be taken care of by web platform tests - mfoltz@ to confirm.
,
Sep 29 2016
,
Nov 10 2016
I've uploaded a CL that tests the ctor of PresentationConnectionAvailableEvent. I did not test the event firing.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/703fb72fa7b04e34ea67a82d003b92a48f1a06c0 commit 703fb72fa7b04e34ea67a82d003b92a48f1a06c0 Author: mlamouri <mlamouri@chromium.org> Date: Wed Nov 16 06:30:35 2016 Add tests for PresentationConnectionAvailable constructor. This is introducing a mock mojo presentation service in LayoutTests which could be used for future tests. BUG= 648922 R=mfoltz@chromium.org Review-Url: https://codereview.chromium.org/2491693003 Cr-Commit-Position: refs/heads/master@{#432394} [add] https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html [add] https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor.html [add] https://crrev.com/703fb72fa7b04e34ea67a82d003b92a48f1a06c0/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
,
Nov 17 2016
mlamouri@ gets credit for fixing this :)
,
Mar 24 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sko...@chromium.org
, Sep 21 2016Labels: Needs-Feedback