New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648910 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.9% regression in memory.top_10_mobile at 419062:419106

Project Member Reported by toyoshim@chromium.org, Sep 21 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=648910

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghZmfrwoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 22 2016

Cc: lunalu@chromium.org
Owner: lunalu@chromium.org

=== Auto-CCing suspected CL author lunalu@chromium.org ===

Hi lunalu@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactoring out the code in LayoutTreeAsText::writeLayoutObject.
Author  : lunalu
Commit description:
  
BUG= 481588 

Review-Url: https://codereview.chromium.org/2280153002
Cr-Commit-Position: refs/heads/master@{#419072}
Commit  : ecf51ddf5158be270b3ad65d613c9498d644fc6b
Date    : Fri Sep 16 01:39:01 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@419061  1430651  1698.75  5  good
chromium@419067  1430323  1003.07  5  good
chromium@419070  1429668  366.268  5  good
chromium@419071  1429504  0.0      5  good
chromium@419072  1446216  732.536  5  bad    <--
chromium@419073  1447035  1698.75  5  bad
chromium@419084  1446871  1775.99  5  bad
chromium@419106  1447362  1575.79  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 648910

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests memory.top_10_mobile
Test Metric: background-memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/after_http_search_yahoo_com_search__ylt_p_google
Relative Change: 1.17%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1628
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000920553177110384


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5853730392506368

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Ping lunalu@, can you please look whether your Cl caused the regression?
Cc: nednguyen@chromium.org
Owner: toyoshim@chromium.org
I don't think it could have. We only added two virtual functions to objects that already have the V-tables. 
Status: WontFix (was: Assigned)
WontFix because we're no longer monitoring ashmem metric

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactoring out the code in LayoutTreeAsText::writeLayoutObject.
Author  : lunalu
Commit description:
  
BUG= 481588 

Review-Url: https://codereview.chromium.org/2280153002
Cr-Commit-Position: refs/heads/master@{#419072}
Commit  : ecf51ddf5158be270b3ad65d613c9498d644fc6b
Date    : Fri Sep 16 01:39:01 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@419061  1505198  3551.98  5  good
chromium@419067  1503232  0.0      5  good
chromium@419070  1503232  0.0      5  good
chromium@419071  1503232  0.0      5  good
chromium@419072  1519616  0.0      5  bad    <--
chromium@419073  1519616  0.0      5  bad
chromium@419084  1522565  3151.59  5  bad
chromium@419106  1521254  3663.57  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 648910

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_https_mobile_twitter_com_justinbieber_skip_interstitial_true
Relative Change: 1.07%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1686
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999523548786156400


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5774975691128832

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment