CL:
https://chromium.googlesource.com/chromium/src/+log/a836bd29e3ca8f3c40a3a4108613a61a2a82f5e7..5207594d819ad2d27561b2c4c77841a47da12eae

https://chromium.googlesource.com/chromium/src/+/5207594d819ad2d27561b2c4c77841a47da12eae - looks like this is expected behaviour.

spqchan@, could you please confirm.

Issue 651128 has been merged into this issue.

Assigning to bettes@ because I have a question in regards to the Guest text color
shrike@ is mentioned that if the text color is black, the user won't tell the difference between the Guest and a normal user. Is there an alternative to making the text color black? Thanks!

Because there might be a custom theme installed we need a solution for a light-backgrounded theme and one for a dark-backgrounded theme.

It looks like Windows does a funky white text with black outline to indicate guest mode. Some kind of icon would be better overall.

Correct me if I'm wrong but dark and light solutions for custom themes does not concern this bug. That is being tracked in  crbug.com/646060 

I disagree with uniquely coloring the text for Guest. It should be colored the same as all other account windows for now. Differentiation can be achieved through visuals further down the road, but we should start with keeping the text consistent. 

> Correct me if I'm wrong but dark and light solutions for custom themes does not concern this bug. That is being tracked in  crbug.com/646060 

646060 only applies if the plan is to display the "Guest" text the same as any other profile label.

> I disagree with uniquely coloring the text for Guest. It should be colored the same as all other account windows for now. Differentiation can be achieved through visuals further down the road, but we should start with keeping the text consistent. 

Currently the browser indicates Guest mode (by changing the text color). I don't have strong feelings about drawing the Guest mode label as we do other profile labels, but want to note again that in so doing there will no longer be an indication that you are in Guest mode. There might be other ways this is indicated in the future, but those methods do not exist now.
 

Reassigning to bettes@

What kind of visuals might be down the road? Icons and different background colors? 

Fyi, I have a CL in progress that will fix this regression and update the text color for the themes: https://codereview.chromium.org/2369663002/

If having the black text color for Guest is okay for M54, I'll go ahead and get this reviewed by an owner. I want to get this merged asap. Thanks!

Yeah let's submit the fix for the black text now and we can think about different visuals for indicating Guest mode later on. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b

commit 28f2ba5dd2bd96becc57e5caf9447e7ce65db96b
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 05 03:05:31 2016

[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG= 646060 , 648890 

Review-Url: https://codereview.chromium.org/2369663002
Cr-Commit-Position: refs/heads/master@{#423060}

[modify] https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm

[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Verified the issue on Mac 10.11.6 using chrome dev version #55.0.2882.0 as per the comment #0 and #1
Observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.

Deleted: 648890.mp4 633 KB

	648890.mp4 633 KB View Download

Do we need this for M54?  We're less than a week from cutting a stable build, and we're typically only taking crash/security fixes, so I'd prefer to wait until M55.

It's a regression that was introduced to M54. It's not too serious, so if it's too close then I'm fine with leaving it for M55.

Ok yeah it's too close for me, thanks for the update!