New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648849 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crash in format

Project Member Reported by ClusterFuzz, Sep 21 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6494221957857280

Fuzzer: libfuzzer_media_vpx_video_decoder_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: UNKNOWN READ
Crash Address: 0x00000000000c
Crash State:
  format
  media::VideoFramePool::PoolImpl::CreateFrame
  media::VideoFramePool::CreateFrame
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=410288:412598

Minimized Testcase (390.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv943aH8Dk5omGt8p4g5GH2uFbQ6vBX_As18MmxDzy81OuTAqKiOoREePOCYA3MdOWnK2OdTLrQgO5ZuRzZbhnn19VJShTHNvf3T_jlQi5dRzCz9GvJy_Bk2M4WDaN2Xp8GjjHStDrWxGlrkOVSHg_sN5C50_C5kxOPMaNZxQHwQ7voybRbg?testcase_id=6494221957857280

Issue manually filed by: brajkumar

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Components: Blink>Media>Video
Labels: -Type-Bug Findit-for-crash M-55 Te-Logged Type-Bug-Regression
Owner: hubbe@chromium.org
Status: Assigned (was: Untriaged)
Providing Findit details for internal purpose:
Suspected CLs	
---------------
The result is a list of CLs that change the crashed files.

Author: hubbe
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/9e40ea52847b6303c81c6e2e64566791a2c960c8
Time: Wed Aug 17 02:25:37 2016
File vpx_video_decoder.cc is changed in this cl (and is part of stack frame #3, "media::VpxVideoDecoder::CopyVpxImageToVideoFrame"; frame #4, "media::VpxVideoDecoder::VpxDecode"; frame #5, "media::VpxVideoDecoder::DecodeBuffer"; frame #6, "media::VpxVideoDecoder::Decode")
Minimum distance from crash line to modified line: 14. (file: vpx_video_decoder.cc, crashed on: 572, modified: 586).

Suspected Project: chromium

using codesearch, seeing observing same changes related to vpx_video_decoder.cc in https://codereview.chromium.org/2247403002

hubbe@, Could you please check the above issue & help us in finding an owner if its not yours.

Comment 2 by hubbe@chromium.org, Sep 21 2016

I'm confused, my change isn't in the range listed on the cluster-fuzz report.
It seems unlikely that my change is causing the problem, and I don't see anything obvious in the range listed. Given that the first CL in the range is "fixed clusterfuzz on mac", perhaps the problem occured before that?
If we can't bisect it, we're just going to have to debug it I guess.

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba53c9cf88833aabbb642e53de195fb150e28f0

commit 2ba53c9cf88833aabbb642e53de195fb150e28f0
Author: hubbe <hubbe@chromium.org>
Date: Thu Sep 22 20:24:00 2016

Fix a fuzzer crash in VideoFramePool

It seems that providing random data to the VPX parser can make it call the video
frame pool with illegal parameters. This currently causes a crash, let's make it
return null, and the calling code already seems to handle that well.

BUG= 648849 

Review-Url: https://codereview.chromium.org/2360373002
Cr-Commit-Position: refs/heads/master@{#420443}

[modify] https://crrev.com/2ba53c9cf88833aabbb642e53de195fb150e28f0/media/base/video_frame_pool.cc

Project Member

Comment 4 by ClusterFuzz, Sep 23 2016

ClusterFuzz has detected this issue as fixed in range 420414:420443.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6494221957857280

Fuzzer: libfuzzer_media_vpx_video_decoder_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: UNKNOWN READ
Crash Address: 0x00000000000c
Crash State:
  format
  media::VideoFramePool::PoolImpl::CreateFrame
  media::VideoFramePool::CreateFrame
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=410288:412598
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_libfuzzer_chrome_asan&range=420414:420443

Minimized Testcase (390.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv943aH8Dk5omGt8p4g5GH2uFbQ6vBX_As18MmxDzy81OuTAqKiOoREePOCYA3MdOWnK2OdTLrQgO5ZuRzZbhnn19VJShTHNvf3T_jlQi5dRzCz9GvJy_Bk2M4WDaN2Xp8GjjHStDrWxGlrkOVSHg_sN5C50_C5kxOPMaNZxQHwQ7voybRbg?testcase_id=6494221957857280

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Sep 23 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: infe...@chromium.org och...@chromium.org chcunningham@chromium.org dalecur...@chromium.org mmoroz@chromium.org kcc@chromium.org nyerramilli@chromium.org
 Issue 593265  has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Oct 2 2017

Components: Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment