New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648839 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature
Team-Security-UX

Blocked on:
issue 648838
issue 689082

Blocking:
issue 646545
issue 647754



Sign in to add a comment

Update SSLStatus when credit cards are detected in a page [iOS]

Project Member Reported by est...@chromium.org, Sep 21 2016

Issue description

Update AutofillDriverIOS to implement NotifyCreditCardFieldShownOnHttp.
It should use its web_state_ member variable to retrieve the visible NavigationItem and update its SSLStatus.
The AutofillManager class is shared between desktop and Bling, so the changes for  issue 648838  will invoke AutofillDriverIOS::NotifyCreditCardFieldShownOnHttp as appropriate.

https://docs.google.com/document/d/1xno6g6OnA7strcyzE-o_drevW8L0Mb6ZBEkjsiwa6x0/edit#heading=h.ontq6o1wpr5o

 
Components: Internals>PageSecurityState
Components: -Security>UX
Blocking: 646545

Comment 4 by est...@chromium.org, Dec 13 2016

Status: Started (was: Assigned)
Cc: lgar...@chromium.org emilyschechter@chromium.org est...@chromium.org
Owner: ----
Status: Available (was: Started)
estark@, I haven't done any work on this yet.
emilyschechter@, how much of a "want" is this for M57?
To confirm: is this the "credit card" piece of HTTP bad Phase 1? The "password" piece was implemented separately?

This is core feature functionality and I think it should match across platforms, so should be prioritized over i.e. Q1 bug fixes, but I'm not exactly sure what else you have on the docket for M57 time frame -- can you help me understand (maybe off-bug) what we're prioritizing this against?
Blocking: 647754
Owner: lgar...@chromium.org
Status: Started (was: Available)
Screen Shot 2017-02-02 at 19.19.51.png
148 KB View Download
Nice! Great work :)
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8965c33248c51c71c273b5957344a974142a6914

commit 8965c33248c51c71c273b5957344a974142a6914
Author: lgarron <lgarron@chromium.org>
Date: Mon Feb 06 00:33:21 2017

iOS: Mark HTTP pages with credit card fields with an omnibox icon.

BUG= 648839 
================================
TEST=Use an iPhone, not an iPad. First, enable the proper flag:
--------------------------------
1. Open the Settings app
2. Scroll to Chrome Beta/Dev/Canary and press
3. Scroll down to Experimental Settings and press
4. Scroll to EXTRA FLAGS (ONE PER LINE)
5. Toggle "Append Extra Flags" to ON
6. Set Flag1 to "--mark-non-secure-as=show-non-secure-passwords-cc-ui" (without the quotes)
--------------------------------
Test 3 URLs:
1) Visit https://badssl.com/input/credit-card/ and verify that the omnibox security has a green lock security indicator to the left of the URL.
2) Visit http://http-credit-card.badssl.com/ and verify that the omnibox security has a grey info icon ⓘ security indicator to the left of the URL.
3) Visit http://http.badssl.com/ and verify that the omnibox does *not* have a security indicator to the left of the URL.
--------------------------------
4) Set Flag1 (see above) to "--mark-non-secure-as=neutral" (without the quotes) and check that http://http-credit-card.badssl.com/ does *not* have a security indicator to the left of the URL.
================================

Review-Url: https://codereview.chromium.org/2669123003
Cr-Commit-Position: refs/heads/master@{#448193}

[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/components/autofill/ios/browser/autofill_driver_ios.mm
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/chrome/browser/ssl/ios_security_state_tab_helper.mm
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/public/ssl_status.h
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/public/web_state/web_state.h
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/8965c33248c51c71c273b5957344a974142a6914/ios/web/web_state/web_state_impl.mm

Blockedon: 689082
Labels: M-58
Status: Fixed (was: Started)

Sign in to add a comment