Update SSLStatus when credit cards are detected in a page [Desktop/Android] |
|||||
Issue descriptionUpdate ContentAutofillDriver to have a new method, NotifyCreditCardFieldShownOnHttp. When called, it should use content::WebContents::FromRenderFrameHost(render_frame_host_) to retrieve a WebContentsImpl and call the OnSensitiveInputShownOnHttp method (described above). Update AutofillManager::ParseForms to identify credit card forms and ask the driver to notify the WebContentsImpl. AutofillManager::OnFormsSeen will need to be updated to invoke ParseForms even if autofill is disabled. OnFormsSeen should take a boolean param that controls whether it’s actually autofilling or just being used to check for HTTP. Call FormStructure::IsCompleteCreditCardForm to check whether the form has credit card fields. If it does have credit card fields, call driver_->NotifyCreditCardFieldShownOnHttp. https://docs.google.com/document/d/1xno6g6OnA7strcyzE-o_drevW8L0Mb6ZBEkjsiwa6x0/edit#heading=h.w17253xjcm3a
,
Oct 17 2016
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3 commit 056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3 Author: estark <estark@chromium.org> Date: Tue Oct 18 17:20:25 2016 Trigger HTTP-bad warning when querying credit card autofill When a user focuses or types in a credit card field, the omnibox should be updated to say "Not secure". This CL implements that behavior by notifying the WebContents when the renderer queries for credit card autofill suggestions. BUG= 648838 Review-Url: https://codereview.chromium.org/2422363002 Cr-Commit-Position: refs/heads/master@{#425999} [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/content/browser/content_autofill_driver.cc [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/content/browser/content_autofill_driver.h [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/content/browser/content_autofill_driver_unittest.cc [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/core/browser/autofill_driver.h [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/core/browser/test_autofill_driver.cc [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/core/browser/test_autofill_driver.h [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/ios/browser/autofill_driver_ios.h [modify] https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3/components/autofill/ios/browser/autofill_driver_ios.mm
,
Oct 18 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label
,
Mar 15 2017
Issue 490500 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by est...@chromium.org
, Sep 21 2016