New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648835 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Same address from Google Wallet appears many times in autofill addresses list

Project Member Reported by chaorenl@chromium.org, Sep 21 2016

Issue description

Chrome Version       : 53.0.2785.116 (Official Build) (64-bit)

What steps will reproduce the problem?
(1) Have a bunch of credit cards on Google Wallet with the same address
(2) Open chrome://settings/autofill

What is the expected result?
One entry for that address

What happens instead?
Same address appears N times, where N is the number of credit cards on Google Wallet

Please provide any additional information below. Attach a screenshot if
possible.
Screenshot had been edited for my privacy, but each entry is identical.
 
Screen Shot 2016-09-20 at 23.04.36.png
57.5 KB View Download

Comment 1 by zkoch@chromium.org, Sep 21 2016

Can you see if the same address appears multiple times as well in Google Payments: https://payments.google.com/manage/w/0/#addressBook:


Comment 2 by zkoch@chromium.org, Sep 21 2016

Components: -UI>Browser>Autofill UI>Browser>Autofill>Payments
It appears a single time in Google Payments. Please see attached screenshot.
Screen Shot 2016-09-21 at 09.11.47.png
58.4 KB View Download

Comment 4 by shrike@chromium.org, Sep 21 2016

Components: -UI>Browser>Autofill>Payments UI>Browser>Autofill

Comment 5 by zkoch@chromium.org, Sep 26 2016

re: #4, shrike, I believe the Payments component is the correct one. This is related to our integration with Google Payments. 

Comment 6 by shrike@chromium.org, Sep 27 2016

Components: -UI>Browser>Autofill UI>Browser>Autofill>Payments
Owner: jdonnelly@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: kevinliu@google.com
Components: Services>Sync
keviniu: this seems like a sync issue (the same credit card entry appearing multiple times). Is there some way we can diagnose what's happening to chaorenl here? Would a screenshot of chrome://sync-internals/ help?

Comment 8 by kevinliu@google.com, Sep 28 2016

Cc: jsaul@google.com jstuppy@google.com
To see the addresses synced down, you can navigate to chrome://sync-internals/, click on the tab "Sync Node Browser", and then open the folder "Autofill Wallet".  An address item should have a name starting with "Address:".

+jstuppy & jsaul.  This is possibly a known issue.  In addition to shipping addresses at the user level, each credit card is associated with a billing address, and thus there could be multiple addresses synced down for a user with multiple credit cards. While I'm not sure about client side deduping, on the server side, jsaul@ added some deduping logic recently (cl/133222081, which is live in dev channel and will be live in stable late this week).  John/Jared, could you add comment or clarification?

Comment 9 by zkoch@chromium.org, Sep 28 2016

This is fundamentally a problem with addresses from Payments. They are not de-duped. So  unless the address is an *exact* match, a duplicate is created. I agree that we need to solve this problem. I'm working on a proposal for how to address this. The short version of the story is: we should stop consistently syncing down addresses from Payments. It should be a one-time sync, where the addresses become local, and can then be put through de-dupe and merge routines.
> So  unless the address is an *exact* match, a duplicate is created.

But these are indeed exact matches.

I think duplicates with minor variations are kind of okay. It's great if you can get rid of them, but not that bad if you can't. I sometimes get those on the Google Payments UI itself, but I could just de-dupe them manually by editing.
Cc: -jsaul@google.com
Owner: jsaul@google.com
jsaul: Is this obsolete?

Comment 12 by jsaul@google.com, Jun 6 2017

Status: WontFix (was: Assigned)
jdonnelly: For the purposes of this bug, I believe so.  sebsg@ landed a change in M58 that should convert server addresses to local addresses, allowing for better client-side de-duping and editing.

I'll close this as Obsolete, but feel free to reopen if you encounter it again.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment