"LoginPromptBrowserTest.TestCancelAuth_OnNavigation" is flaky |
|||
Issue description"LoginPromptBrowserTest.TestCancelAuth_OnNavigation" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJMb2dpblByb21wdEJyb3dzZXJUZXN0LlRlc3RDYW5jZWxBdXRoX09uTmF2aWdhdGlvbgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40bdd13e48cee72c4d67437ca4f0a0447a08a1d commit d40bdd13e48cee72c4d67437ca4f0a0447a08a1d Author: ymalik <ymalik@chromium.org> Date: Wed Sep 21 16:16:11 2016 Disable flaky LoginPromptBrowserTest.TestCancelAuth_OnNavigation test on Linux ChromeOS BUG= 648826 TBR=davidben@chromium.org Review-Url: https://codereview.chromium.org/2360683002 Cr-Commit-Position: refs/heads/master@{#420076} [modify] https://crrev.com/d40bdd13e48cee72c4d67437ca4f0a0447a08a1d/chrome/browser/ui/login/login_handler_browsertest.cc
,
Sep 27 2016
I'm working on it. It looks like there is an additional NOTIFICATION_LOAD_STOP event from the interstitial, which causes flaky behaviour. Actually we should wait for 3 LOAD_STOP events in this test.
,
Sep 27 2016
Thanks for the update and for looking into this! Happy to review any CL. :)
,
Sep 28 2016
sense@ fixed the test in https://codereview.chromium.org/2371423002/, so closing this bug.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccdf28fd10f131452af38b709106bd14409d5c06 commit ccdf28fd10f131452af38b709106bd14409d5c06 Author: sense <sense@yandex-team.ru> Date: Wed Sep 28 08:27:39 2016 Fix LoginPromptBrowserTest.TestCancelAuth_OnNavigation test flakiness. On navigation to a different origin (empty page -> kAuthUrl) we have an interstitial which generates an additional LOAD_STOP event. We should count it in WindowedLoadStopObserver. BUG= 648826 R=vabr@chromium.org Review-Url: https://codereview.chromium.org/2371423002 Cr-Commit-Position: refs/heads/master@{#421481} [modify] https://crrev.com/ccdf28fd10f131452af38b709106bd14409d5c06/chrome/browser/ui/login/login_handler_browsertest.cc
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8168f6ff165cb2bf59317284eaae2d04e2bc8a1 commit f8168f6ff165cb2bf59317284eaae2d04e2bc8a1 Author: vabr <vabr@chromium.org> Date: Wed Sep 28 16:45:30 2016 Fix TestCancelAuth_OnNavigation for PlzNavigation LoginPromptBrowserTest.TestCancelAuth_OnNavigation expects 3 LOAD_STOP events for a sequence of: HTTP login interstitial, navigation to auth page, forced navigation to some other page. Under PlzNavigate, there is one less LOAD_STOP event due to not getting a LOAD_STOP for ongoing navigation when another one is triggered [1]. This CL adjusts the test to cope with PlzNavigate. [1] https://codereview.chromium.org/2371423002/#msg12 R=nasko@chromium.org BUG= 648826 Review-Url: https://codereview.chromium.org/2377043002 Cr-Commit-Position: refs/heads/master@{#421545} [modify] https://crrev.com/f8168f6ff165cb2bf59317284eaae2d04e2bc8a1/chrome/browser/ui/login/login_handler_browsertest.cc
,
Nov 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ymalik@chromium.org
, Sep 21 2016Labels: -Sheriff-Chromium
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)