New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648789 link

Starred by 2 users
Status: Assigned
Owner:
█ talo@chromium.org
Last visit 20 days ago
Cc:
█ dim...@chromium.org
fgor...@chromium.org
█ talo@chromium.org
█ rachelis@chromium.org
dougarnett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

downloading offline page shows no percentage progress in notification

Project Member Reported by qin...@chromium.org, Sep 20 2016 
Steps to reproduce:
(1) Click any link, any click "save linked page for later"
(2) Offline download starts, but the progress doesn;t show any percentage, it will to complete when it is done though

Comment 1 by dougarnett@chromium.org, Sep 21 2016

Cc: dougarnett@chromium.org fgor...@chromium.org
I'm not sure about manufacturing some percentage (not sure where that ended up product definition wise) but a first step would be to surface when we are actually trying to load a page vs. it just being queued. Then we could discuss exposing some coarse steps perhaps for DOMContentLoaded, OnLoad, and then snapshotting mhtml if we have a UX that can leverage them (percentage is a tricky fit though).

Comment 2 by fgor...@chromium.org, Sep 21 2016

Cc: talo@chromium.org dim...@chromium.org
Components: UI>Browser>Offline
Sounds like feature request.

Comment 3 by qin...@chromium.org, Sep 21 2016 

WebContentsDelegate will gave us the percentage during loading. we can say the percentage is 99% when loading stops. Normal download already have the calls to report progress notifications.

Comment 4 by dim...@chromium.org, Sep 21 2016 

Page loads spend long tim ebefore starting to load anything, then they are done quickly. It would probably be better UX to indicate "waiting for download" state rather that a 0 or 1% being stuck for a long time. Looking forward for UI guidance on this feature.

Comment 5 by dim...@chromium.org, Sep 21 2016

Cc: rachelis@chromium.org
Labels: Type-Feature
Owner: talo@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b0778d13de1e5c0afe784792ad6709b2f5ffad

commit 13b0778d13de1e5c0afe784792ad6709b2f5ffad
Author: qinmin <qinmin@chromium.org>
Date: Wed Sep 21 23:39:55 2016

Fix an issue that PrerenderLoader::OnPrerenderStart() never gets called.

When calling PrerenderManager::AddPrerenderForOffline(),
OnPrerenderStart() is get called inside it.
Since the observer is not yet added to active_handle_, PrerenderLoader will miss the call.
This CL fixes the issue.

BUG=648789

Review-Url: https://codereview.chromium.org/2357013002
Cr-Commit-Position: refs/heads/master@{#420200}

[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerender_adapter.cc
[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerender_adapter.h
[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerender_adapter_unittest.cc
[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerendering_loader.cc
[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerendering_loader.h
[modify] https://crrev.com/13b0778d13de1e5c0afe784792ad6709b2f5ffad/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Comment 7 by dewittj@chromium.org, Sep 23 2016

Labels: -Pri-3 Pri-2
Status: Assigned (was: Unconfirmed)
(triage)

See doc at https://docs.google.com/document/d/1kgwZDF8yfqCVa3zQUK6EudQjDAXIvYlAS6bPz3hkVlk/edit?ts=57e43b6b
►

Sign in to add a comment