New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648788 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

API Keys missing from bisect builds

Project Member Reported by glevin@chromium.org, Sep 20 2016

Issue description

Version: 55.0.2861.0
OS: Chrome

What steps will reproduce the problem?
(1) Run a ChromeOS bisect to test login ("python tools/bisect-builds.py -a chromeos ...  --login-manager ...")

What is the expected output?
A Chrome OS desktop where I can log in

What do you see instead?
Black error bar above login dialog which reads,
"You will not be able to add users because Google API keys are missing. See http://www.chromium.org/developers/how-tos/api-keys for details."
Login attempts fail.

My guess (and it's just a guess) is that this is a similar problem to  Issue 628432  (GYP -> GN), but since I'm not building the bisect binaries, modifying my build strings or args.gn won't help.  If there's an easy fix that I can apply on my own, then at a minimum, http://dev.chromium.org/developers/bisect-builds-py should be updated with that information.

+chirantan@, stevenjb@, ihf@ : Author / selected commentors on  Issue 628432 
+anantha@ : Owner and recent code reviewer on bisect-builds.py




 

Comment 1 by ihf@chromium.org, Sep 20 2016

This just means that you are using chromium builds. These are built without API keys baked in. The solution is either to
a) build/use Chrome branded binaries or
b) instruct user to install personal API keys in /etc/chrome_dev.conf

Comment 2 by glevin@chromium.org, Sep 21 2016

For (a), 
https://sites.google.com/a/google.com/chrome-te/home/tools/bisect-builds
indicates that I should use the -o flag, but that appears to have been removed by https://codereview.chromium.org/1970613004.  Is there a new, preferred way to bisect on official builds?

Does (b) work when I'm running on my Linux desktop?  If so, where would I put the chrome_dev.conf so that downloaded bisect builds would find it?

Comment 3 by ihf@chromium.org, Sep 21 2016

b) You put the keys in environmnent variables, see bottom of
https://www.chromium.org/developers/how-tos/api-keys

a) I don't have experience with -o.

Comment 4 by glevin@chromium.org, Sep 21 2016

> b) You put the keys in environmnent variables, see bottom of
> https://www.chromium.org/developers/how-tos/api-keys

Right, the "Providing Keys at Runtime" section says to put the keys in /etc/chrome_dev.conf, which I assume would work if I was running on a device.  But I'm running the bisect on my Linux desktop, and putting chrome_dev.conf in my file system's /etc directory isn't working.  So I'm wondering, once I've got the API keys in chrome_dev.conf, where do I put that file in my Linux desktop filesystem so that the bisect binaries (which are being downloaded to and run from a temp directory like "/tmp/bisect_tmphAP7v3/chrome-linux") can find and use them?
You can set the environment variables directly, I just tried it and it works.

Googlers can search for "simplified_approach_for_chrome_api_keys" in our internal docs



Comment 6 by ihf@chromium.org, Sep 21 2016

Indeed, on a desktop you just put the keys in the environment variables without a need for chrome_dev.conf.

Comment 7 by glevin@chromium.org, Sep 21 2016

Components: -Tools Infra>Documentation
Ah, got it... that's the bit I was missing.  Thanks for the info!  I've added a comment to https://sites.google.com/a/chromium.org/dev/developers/bisect-builds-py .  Once that gets updated, I'll consider the matter resolved to my satisfaction :-)

Comment 8 by ihf@chromium.org, Sep 21 2016

You can edit the page with your chromium account. Just sign in on the bottom and then edit (I think on top).
Cc: -glevin@chromium.org
Owner: glevin@chromium.org
Status: Fixed (was: Available)
Updated https://sites.google.com/a/chromium.org/dev/developers/bisect-builds-py , so the fix is now hopefully easy to find.
Labels: VerifyIn-55

Comment 11 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 12 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 13 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 14 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 15 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment