API Keys missing from bisect builds |
||||||||||||
Issue description
Version: 55.0.2861.0
OS: Chrome
What steps will reproduce the problem?
(1) Run a ChromeOS bisect to test login ("python tools/bisect-builds.py -a chromeos ... --login-manager ...")
What is the expected output?
A Chrome OS desktop where I can log in
What do you see instead?
Black error bar above login dialog which reads,
"You will not be able to add users because Google API keys are missing. See http://www.chromium.org/developers/how-tos/api-keys for details."
Login attempts fail.
My guess (and it's just a guess) is that this is a similar problem to Issue 628432 (GYP -> GN), but since I'm not building the bisect binaries, modifying my build strings or args.gn won't help. If there's an easy fix that I can apply on my own, then at a minimum, http://dev.chromium.org/developers/bisect-builds-py should be updated with that information.
+chirantan@, stevenjb@, ihf@ : Author / selected commentors on Issue 628432
+anantha@ : Owner and recent code reviewer on bisect-builds.py
,
Sep 21 2016
For (a), https://sites.google.com/a/google.com/chrome-te/home/tools/bisect-builds indicates that I should use the -o flag, but that appears to have been removed by https://codereview.chromium.org/1970613004. Is there a new, preferred way to bisect on official builds? Does (b) work when I'm running on my Linux desktop? If so, where would I put the chrome_dev.conf so that downloaded bisect builds would find it?
,
Sep 21 2016
b) You put the keys in environmnent variables, see bottom of https://www.chromium.org/developers/how-tos/api-keys a) I don't have experience with -o.
,
Sep 21 2016
> b) You put the keys in environmnent variables, see bottom of > https://www.chromium.org/developers/how-tos/api-keys Right, the "Providing Keys at Runtime" section says to put the keys in /etc/chrome_dev.conf, which I assume would work if I was running on a device. But I'm running the bisect on my Linux desktop, and putting chrome_dev.conf in my file system's /etc directory isn't working. So I'm wondering, once I've got the API keys in chrome_dev.conf, where do I put that file in my Linux desktop filesystem so that the bisect binaries (which are being downloaded to and run from a temp directory like "/tmp/bisect_tmphAP7v3/chrome-linux") can find and use them?
,
Sep 21 2016
You can set the environment variables directly, I just tried it and it works. Googlers can search for "simplified_approach_for_chrome_api_keys" in our internal docs
,
Sep 21 2016
Indeed, on a desktop you just put the keys in the environment variables without a need for chrome_dev.conf.
,
Sep 21 2016
Ah, got it... that's the bit I was missing. Thanks for the info! I've added a comment to https://sites.google.com/a/chromium.org/dev/developers/bisect-builds-py . Once that gets updated, I'll consider the matter resolved to my satisfaction :-)
,
Sep 21 2016
You can edit the page with your chromium account. Just sign in on the bottom and then edit (I think on top).
,
Oct 5 2016
Updated https://sites.google.com/a/chromium.org/dev/developers/bisect-builds-py , so the fix is now hopefully easy to find.
,
Oct 7 2016
,
Oct 10 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ihf@chromium.org
, Sep 20 2016