This includes service workers, future out-of-process subframes, browser domain and potentially workers.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baa93361a05da208379a95578ed2b1abc2ece477 commit baa93361a05da208379a95578ed2b1abc2ece477 Author: dgozman <dgozman@chromium.org> Date: Tue Sep 27 18:06:31 2016 Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates. We lacked these ids in OnNewLiveVersion and there were no updates when they changed. BUG= 648775 Review-Url: https://codereview.chromium.org/2365053002 Cr-Commit-Position: refs/heads/master@{#421264} [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/embedded_worker_instance.h [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_context_core.h [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_context_observer.h [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_context_watcher.cc [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_context_watcher.h [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/baa93361a05da208379a95578ed2b1abc2ece477/content/browser/service_worker/service_worker_version.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a commit c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a Author: dgozman <dgozman@chromium.org> Date: Wed Sep 28 03:27:55 2016 [DevTools] Move subtargets functionality from ServiceWorker to Target domain. BUG= 648775 Review-Url: https://codereview.chromium.org/2354973003 Cr-Commit-Position: refs/heads/master@{#421437} [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/BUILD.gn [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/protocol/schema_handler.cc [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/protocol/service_worker_handler.h [add] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/protocol/target_handler.cc [add] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js [add] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js [modify] https://crrev.com/c2cea7d490e0b9ec93b72b0e00502bb9fa79f10a/third_party/WebKit/Source/devtools/front_end/sdk/module.json
We could also merge "auto-attach to created pages" here.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c commit 5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c Author: dgozman <dgozman@chromium.org> Date: Sat Oct 01 02:12:37 2016 [DevTools] Support Target.setWaitForDebuggerOnStart. Set to false while profiling. Tests are coming next. BUG= 648775 Review-Url: https://codereview.chromium.org/2387773003 Cr-Commit-Position: refs/heads/master@{#422284} [modify] https://crrev.com/5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c/content/browser/devtools/protocol/target_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1921bdaf02e1a61af60f27a7529f3b97a0018ad0 commit 1921bdaf02e1a61af60f27a7529f3b97a0018ad0 Author: dgozman <dgozman@chromium.org> Date: Mon Oct 03 20:23:51 2016 [DevTools] Update inspector/service-workers tests. Added service-worker-pause.html. Updated expectations on some tests. BUG= 648775 , 480769 , 564403 Review-Url: https://codereview.chromium.org/2388933002 Cr-Commit-Position: refs/heads/master@{#422511} [modify] https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/resources/service-worker-debugger.js [add] https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-pause-expected.txt [add] https://crrev.com/1921bdaf02e1a61af60f27a7529f3b97a0018ad0/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-pause.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/478ac0e1bbcd86ebddb50816261f93392fa881f4 commit 478ac0e1bbcd86ebddb50816261f93392fa881f4 Author: dgozman <dgozman@chromium.org> Date: Mon Oct 03 22:05:31 2016 [DevTools] Auto-attach to cross-process subframes under experiment. Fixed immediate UI problems by introducing TargetNameChanged event. This is enough for the targets scope, modulo attach/detach tests. UI polish would be addressed later under a separate bug. BUG= 648775 Review-Url: https://codereview.chromium.org/2383743003 Cr-Commit-Position: refs/heads/master@{#422553} [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js [modify] https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d commit bf5f253616dfb7f6bb1f3e490b2a0804561dea5d Author: dgozman <dgozman@chromium.org> Date: Tue Oct 04 02:24:37 2016 [DevTools] Introduce Target.setAutoAttach. This separates passive "listen to all targets" behavior from "auto-attach to related targets" required by DevTools frontend. BUG= 648775 Review-Url: https://codereview.chromium.org/2391823002 Cr-Commit-Position: refs/heads/master@{#422674} [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js [modify] https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b53ab6afaf075529678e8ce6ea082dd03935a8d commit 4b53ab6afaf075529678e8ce6ea082dd03935a8d Author: dgozman <dgozman@chromium.org> Date: Wed Oct 05 23:24:10 2016 [DevTools] Support all targets discovery in Target domain. This is protocol-only change, no implementation yet. BUG= 648775 Review-Url: https://codereview.chromium.org/2387283003 Cr-Commit-Position: refs/heads/master@{#423334} [modify] https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aa558fd82627ea7acbf9affc3823367e43c74aa commit 6aa558fd82627ea7acbf9affc3823367e43c74aa Author: dgozman <dgozman@chromium.org> Date: Tue Oct 11 03:16:59 2016 [DevTools] Fix a couple of issues for cross-site RFDTAH, add a test. - Fixed NPE in GetType(), GetTitle() and GetDescription(). - Fallback to default GetType() when not provided by delegate. - Fixed UAF when CommitPending() destructed |this| (triggered in DHCECKs only). - Test for Target domain with OOPIFs. BUG= 648775 Review-Url: https://codereview.chromium.org/2397713003 Cr-Commit-Position: refs/heads/master@{#424358} [modify] https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa/content/public/browser/devtools_manager_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47679eb123c83bec2bb19d54b0386c67f7e6859e commit 47679eb123c83bec2bb19d54b0386c67f7e6859e Author: dgozman <dgozman@chromium.org> Date: Mon Oct 17 17:30:18 2016 [DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. - This allows to add more methods to observer. - Migrated clients. - Issuing notifications from the base class. BUG= 648775 TBR=bauerb@chromium.org,avi@chormium.org Review-Url: https://codereview.chromium.org/2419943002 Cr-Commit-Position: refs/heads/master@{#425714} [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/android/devtools_manager_delegate_android.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/ui/views/extensions/extension_popup.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/chrome/browser/ui/views/extensions/extension_popup.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/devtools_manager.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/devtools_manager.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/public/browser/BUILD.gn [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/public/browser/devtools_agent_host.h [add] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/public/browser/devtools_agent_host_observer.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/public/browser/devtools_manager_delegate.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/extensions/browser/app_window/app_window_registry.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/extensions/browser/app_window/app_window_registry.h [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/extensions/browser/process_manager.cc [modify] https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e/extensions/browser/process_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e20708992845f6028098b2530dfd1bd3d4c7cc commit d3e20708992845f6028098b2530dfd1bd3d4c7cc Author: dgozman <dgozman@chromium.org> Date: Wed Oct 19 14:53:13 2016 [DevTools] Split device discovery off DevToolsAnrdoidBridge. This will be reused by ChromeDevToolsManagerDelegate. BUG= 648775 Review-Url: https://chromiumcodereview.appspot.com/2431483003 Cr-Commit-Position: refs/heads/master@{#426186} [modify] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/BUILD.gn [modify] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/device/devtools_android_bridge.h [add] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/device/devtools_device_discovery.cc [add] https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc/chrome/browser/devtools/device/devtools_device_discovery.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70 commit f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70 Author: dgozman <dgozman@chromium.org> Date: Wed Oct 19 17:45:15 2016 [DevTools] Implement Target.setDiscoverTargets method. When discovery is enabled, we force agents hosts for all web contents and report all available agent hosts to the client. BUG= 648775 Review-Url: https://chromiumcodereview.appspot.com/2408133004 Cr-Commit-Position: refs/heads/master@{#426239} [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/public/browser/BUILD.gn [add] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/public/browser/devtools_agent_host_observer.cc [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/content/public/browser/devtools_agent_host_observer.h [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/f00c4f7bc478b2f9ce9ba2dec7f18737ee461d70/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a134aa69d1184e0ff32a10768b646cf723660e41 commit a134aa69d1184e0ff32a10768b646cf723660e41 Author: dgozman <dgozman@chromium.org> Date: Thu Oct 20 03:39:01 2016 [DevTools] Switch remote locations to Target domain. - Moves setRemoteLocations from Browser to Target. - Destroys agent host on remote connection closure, keeping devtools window alive. - Fixes manager delegates not adding themselves as observers. - Cleans up external agent hosts on detaches. BUG= 648775 TBR=bauerb@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437633003 Cr-Commit-Position: refs/heads/master@{#426391} [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/device/devtools_device_discovery.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/device/devtools_device_discovery.h [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/devtools_network_controller.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/chrome/browser/devtools/devtools_window.h [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/content/browser/devtools/protocol/browser_handler.h [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/third_party/WebKit/Source/devtools/front_end/main/Main.js [delete] https://crrev.com/adbac885e434506ee33ef7651a9129443086de27/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/third_party/WebKit/Source/devtools/front_end/main/module.json [modify] https://crrev.com/a134aa69d1184e0ff32a10768b646cf723660e41/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a91888d84288248b3a2b9c301cdaa4e46c5ee22e commit a91888d84288248b3a2b9c301cdaa4e46c5ee22e Author: dgozman <dgozman@chromium.org> Date: Tue Oct 25 21:33:53 2016 [DevTools] Remove Browser domain, switch clients to Target. BUG= 648775 Review-Url: https://codereview.chromium.org/2436763003 Cr-Commit-Position: refs/heads/master@{#427483} [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/BUILD.gn [delete] https://crrev.com/43de8ce7588866b2ce0eefa9ccf9f570c22f1df7/content/browser/devtools/protocol/browser_handler.cc [delete] https://crrev.com/43de8ce7588866b2ce0eefa9ccf9f570c22f1df7/content/browser/devtools/protocol/browser_handler.h [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/protocol/schema_handler.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/protocol/target_handler.h [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/BUILD.gn [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/lib/browser/headless_devtools_client_impl.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/lib/browser/headless_devtools_client_impl.h [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/lib/headless_devtools_client_browsertest.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/public/headless_devtools_client.h [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/headless/public/util/dom_tree_extractor_browsertest.cc [modify] https://crrev.com/a91888d84288248b3a2b9c301cdaa4e46c5ee22e/third_party/WebKit/Source/core/inspector/browser_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6274a2d207fc8383d1182204b2a900d80c3d3f0e commit 6274a2d207fc8383d1182204b2a900d80c3d3f0e Author: dgozman <dgozman@chromium.org> Date: Tue Oct 25 23:00:51 2016 [DevTools] Refactor connection-related classes. Extracted small connection interface, it's params and factory. Supported connect/disconnect for all main connection types. Renamed previous Connection to TargetPrototype, which will be merged to Target soon. BUG= 648775 Review-Url: https://codereview.chromium.org/2441933002 Cr-Commit-Position: refs/heads/master@{#427521} [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents.html [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/Tests.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js [modify] https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f686f0789e3d08cf5fc4f24292081f533a1f03 commit d4f686f0789e3d08cf5fc4f24292081f533a1f03 Author: dgozman <dgozman@chromium.org> Date: Wed Oct 26 01:23:21 2016 [DevTools] Inherit WI.Target from Protocol.Target. Fixed compilation in multiple places. BUG= 648775 Review-Url: https://codereview.chromium.org/2450973002 Cr-Commit-Position: refs/heads/master@{#427563} [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/elements/styles-1/cached-sync-computed-styles.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-loader.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/report-API-errors.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/common/Color.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/scripts/compile_frontend.py [modify] https://crrev.com/d4f686f0789e3d08cf5fc4f24292081f533a1f03/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14d5ae1493499885e5f9820490e77aef43d0d083 commit 14d5ae1493499885e5f9820490e77aef43d0d083 Author: dgozman <dgozman@chromium.org> Date: Wed Oct 26 22:35:33 2016 [DevTools] Merge Worker domain to Target, migrate clients. BUG= 648775 Review-Url: https://codereview.chromium.org/2442083002 Cr-Commit-Position: refs/heads/master@{#427853} [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/content/browser/devtools/protocol/schema_handler.cc [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/content/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/dedicated-workers-list.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents-expected.txt [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-evaluate-in-worker-while-pause-in-page.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker-loop.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-pause-dedicated-worker.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setTimeout-sourceUrl-dedicated-worker-loop.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-terminate-dedicated-worker-while-paused.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js [delete] https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/sdk/module.json [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js [modify] https://crrev.com/14d5ae1493499885e5f9820490e77aef43d0d083/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/484e19f6aa51fc3b24be33cd7ae26d5030b56367 commit 484e19f6aa51fc3b24be33cd7ae26d5030b56367 Author: dgozman <dgozman@chromium.org> Date: Fri Oct 28 07:37:31 2016 [DevTools] Move main target/connection to TargetManager. This fixes a bunch of issues: - removes indirection for interceptMainConnection; - properly handles websocket disconnected screen; - correctly names Node target. BUG= 648775 Review-Url: https://codereview.chromium.org/2451363002 Cr-Commit-Position: refs/heads/master@{#428309} [modify] https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js [modify] https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367/third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js [modify] https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js [modify] https://crrev.com/484e19f6aa51fc3b24be33cd7ae26d5030b56367/third_party/WebKit/Source/devtools/services/devtools.js
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by bugdroid1@chromium.org
, Sep 28 2016