New issue
Advanced search Search tips

Issue 648753 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Dec 2016
Cc:
jonr...@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 557399



Sign in to add a comment

Login UI - Needs Refactored TouchView delegate

Project Member Reported by jonr...@chromium.org, Sep 20 2016 
Currently the login ui interacts with touch view via TouchViewControllerDelegate with is a ShellObserver.

When running in mash ash::Shell has no instance, so the observer is not available.

We should pull the touch view related methods into a separate observer, so that login accesses that service directly.

Comment 1 by jamescook@chromium.org, Sep 21 2016

Summary: Login UI - Needs Refactored TouchView delegate (was: Login UI - Needs Refactored TochView delegate)

Comment 2 by jonr...@chromium.org, Sep 21 2016

Owner: jonr...@chromium.org
Status: Assigned (was: Available)

Comment 3 by rjkroege@chromium.org, Oct 4 2016

Labels: Proj-Mustash

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS

Comment 5 by jonr...@chromium.org, Oct 18 2016 

Plan:

Create ash/public/interfaces/touch_view.mojom

To handle chrome-ash communication.

Remove TouchViewControllerDelegate. Have SigninScreenHandler become a listener of the the new mojom.

On ash side implement touch_view mojom via current shellobserver
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c85c81962fc4e37368c1562978fce94bfba6cd92

commit c85c81962fc4e37368c1562978fce94bfba6cd92
Author: jonross <jonross@chromium.org>
Date: Fri Dec 02 17:18:44 2016

A new mojom so that chrome/browser can learn of touchview state changes which occur on ash.

TEST=manually tested login screen in normal CrOS builds as well as with the mash flag
BUG= 648753 

Review-Url: https://codereview.chromium.org/2505403003
Cr-Commit-Position: refs/heads/master@{#435961}

[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/common/mojo_interface_factory.cc
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/common/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/common/wm/maximize_mode/maximize_mode_controller.h
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/mus/manifest.json
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/ash/public/interfaces/touch_view.mojom
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/c85c81962fc4e37368c1562978fce94bfba6cd92/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[delete] https://crrev.com/c654fbbf22e44c70cefdf01e9bdfffaabf837996/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc
[delete] https://crrev.com/c654fbbf22e44c70cefdf01e9bdfffaabf837996/chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.h

Comment 7 by jonr...@chromium.org, Dec 5 2016

Status: Fixed (was: Assigned)

Comment 8 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 9 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment