New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648749 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabledNullProfileSyncService" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 20 2016 
"org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabledNullProfileSyncService" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybAsSBUZsYWtlImFvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucHJlY2FjaGUuUHJlY2FjaGVMYXVuY2hlclRlc3QjdGVzdFVwZGF0ZUVuYWJsZWROdWxsUHJvZmlsZVN5bmNTZXJ2aWNlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by boliu@chromium.org, Sep 20 2016 

this test already has @RetryOnFailure, so it's being retried up to 3 times already, yet still flake enough to have this filed

flakiness dashboard is down at the moment, so can't tell if it only became flaky recently :/

safest thing is probably disable

Comment 2 by boliu@chromium.org, Sep 20 2016

Owner: maxbogue@chromium.org
Status: Assigned (was: Untriaged)
guestimate maxbogue as owner

Comment 3 by boliu@chromium.org, Sep 20 2016

Labels: -Sheriff-Chromium
CL to disable in cq: https://codereview.chromium.org/2354103002/

Comment 4 by ymalik@chromium.org, Sep 20 2016 

From the first flake in the list of all flakes, I see that this started happening in this range: https://chromium.googlesource.com/chromium/src/+log/bc94e6ac4ddf98fc838684b079d70dae943b55d3?pretty=fuller

Suspecting https://codereview.chromium.org/2333063002 but not entirely sure as that CL is only adding UMA metrics and there are other changes that may be relevant.

Comment 5 by boliu@chromium.org, Sep 20 2016 

try-flake doesn't really help with flake history (imo) because it ignores runs that pass on retry
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841d5eca72fd51cc28d7c0367138075f574d2074

commit 841d5eca72fd51cc28d7c0367138075f574d2074
Author: boliu <boliu@chromium.org>
Date: Tue Sep 20 22:49:17 2016

Disable PrecacheLauncherTest#testUpdateEnabledNullProfileSyncService

BUG= 648749 
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2354103002
Cr-Commit-Position: refs/heads/master@{#419879}

[modify] https://crrev.com/841d5eca72fd51cc28d7c0367138075f574d2074/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

Comment 7 by ymalik@chromium.org, Sep 21 2016 

 Issue 648952  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf21d2047f3e9b43ef1f9c6bb6257ef48d98758

commit 6bf21d2047f3e9b43ef1f9c6bb6257ef48d98758
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Sep 27 22:45:32 2016

[Sync] Try to fix PrecacheLauncher test flakiness.

Looks like ContextUtils was not always properly initialized with the
application context. Successfully ran the tests 250+ times without
getting a flake after this fix.

BUG= 648749 

Review-Url: https://codereview.chromium.org/2369653002
Cr-Commit-Position: refs/heads/master@{#421369}

[modify] https://crrev.com/6bf21d2047f3e9b43ef1f9c6bb6257ef48d98758/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java

Comment 9 by maxbogue@chromium.org, Sep 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment