New issue
Advanced search Search tips

Issue 648733 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 646565
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 679782
issue 557399
issue 646565



Sign in to add a comment

Login UI - Virtual Keyboard

Project Member Reported by jonr...@chromium.org, Sep 20 2016

Issue description

When running Login in Mash the ash::Shell instance is not available.

Currently ShellObserver::OnVirtualKeyboardStateChanged is tied to the Shell. We need to split this out to enable the virtual keyboard with mash login
 
Components: MUS
Labels: Proj-Mustash-Chrome

Comment 2 by xiy...@chromium.org, Sep 21 2016

Labels: OS-Chrome
Owner: xiy...@chromium.org
Status: Assigned (was: Available)
Labels: Proj-Mustash
Components: Internals>MUS

Comment 5 by sky@chromium.org, Mar 2 2017

585253 is for getting keyboard to work with mash.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca38d4605fa46a7822ca5522db352415d97eed4

commit eca38d4605fa46a7822ca5522db352415d97eed4
Author: sky <sky@chromium.org>
Date: Fri Mar 03 05:21:56 2017

chromeos: moves more ash tests to run on mash

And pointers to bugs for those that aren't moved to common.

BUG= 631103 , 633782 , 634994 , 648733 , 695887 , 696752 ,696754, 698016 , 698024 ,698032,698033, 698043 , 698049 ,698060,698085, 698092 ,698093, 698129 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2732573002
Cr-Commit-Position: refs/heads/master@{#454514}

[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/BUILD.gn
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/workspace/workspace_window_resizer_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8

commit ea37af717f1569dd93282e09b6fb49ff22b771f8
Author: sky <sky@chromium.org>
Date: Tue Mar 07 22:59:41 2017

Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}

[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc

Comment 8 by xiy...@chromium.org, Apr 12 2017

Cc: jdufault@chromium.org
+jdufault

This the master bug that tracks the VK work for login UI. I have not really started work on it though. :p
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Blocking: 646565
Cc: -xiy...@chromium.org steve...@chromium.org
Steven, do you want to fold this bug into the master VK bug?
xiyuan@ / jdufault@ - Are you aware of anything login specific for the virtual keyboard? If not then we should just merge this with  issue 646565 .

Login code (e.g. WebUILoginView::OnKeyboardVisibilityStateChanged) observes on-screne keyboard so that it could re-layout properly when the keyboard shows/hides.

I think we could merge this into the master bug since how login screen handles this largely depends on the design of mash on-screen keyboard design.
Blocking: 679782
Labels: Pri-2
Mergedinto: 646565
Status: Duplicate (was: Assigned)
As Xiyuan suggestions, merging this into master bug

Sign in to add a comment