New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648726 link

Starred by 1 user
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove deprecated PageLoad.Timing2 histograms

Project Member Reported by bmcquade@chromium.org, Sep 20 2016 
We've moved from PageLoad.Timing2 to PageLoad.PaintTiming and variants, but some code continues to log Timing2 metrics. As part of our effort to finalize the transition from PLT.* to PageLoad.* we should clean this up so we're only logging supported metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e915bc7618c1e48299060bf8a45d1c8c53c6ef25

commit e915bc7618c1e48299060bf8a45d1c8c53c6ef25
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Sep 26 20:46:39 2016

Remove the Timing2 histograms that are deprecated.

The document.write observer was still logging a few Timing2 histograms,
which prevented us from deprecating them. Now that the new versions of
these histograms have rolled out to stable, we can safely remove the old
ones and mark the base Timing2 histograms as deprecated.

BUG= 648726 

Review-Url: https://codereview.chromium.org/2359523003
Cr-Commit-Position: refs/heads/master@{#420985}

[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/chrome/browser/page_load_metrics/page_load_metrics_util.cc
[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/chrome/browser/page_load_metrics/page_load_metrics_util.h
[modify] https://crrev.com/e915bc7618c1e48299060bf8a45d1c8c53c6ef25/tools/metrics/histograms/histograms.xml

Comment 2 by bmcquade@chromium.org, Sep 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment