New issue
Advanced search Search tips

Issue 648720 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2018
Cc:
torne@chromium.org
agrieve@chromium.org
dpranke@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

deps of generate_webview_license_notice isn't correct

Project Member Reported by michaelbai@chromium.org, Sep 20 2016 
The android_webview/tools/webview_licenses.py scans all third_party directoris to collect the license information, but we never set this target's deps correctly, which caused webview license isn't generated correctly in incremental build, e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=631494#c35

To be clear, this works fine for release bot as it is always fresh build.

We should only collect the license that webview actually uses instead of all in third party, so the fix might be

- add all native and Java(do you need include Java for license purpose?) targets that WebView depends on to the deps file, and send it to script.

- script only collects the license in deps file.

Comment 1 by torne@chromium.org, Sep 21 2016 

I think there's an existing bug for the fact that the license generation (not just for webview, but for chrome itself as well) collects a bunch of licenses that aren't actually used by the current binary/operating system/etc, and it's so far been an unsolved problem.

If you think this can be done via deps then that would be pretty neat, but if we're going to make that kind of change it shouldn't be webview-specific, and we'd need to be sure that it doesn't miss anything that's actually used but in a way that's not obvious from the deps graph?

Comment 2 by agrieve@chromium.org, Sep 21 2016

Cc: dpranke@chromium.org
The existing bug for trimming this down is bug #178215. I think I saw Dirk at some point mention adding this as a feature to GN as well (just like Bazel does). Can't seem to find that though.

Comment 3 by dpranke@chromium.org, Sep 21 2016 

I think you're talking about bug 469261.

Comment 4 by ntfschr@chromium.org, May 10 2017

Status: Available (was: Untriaged)
Moving to "available" as per new bug triaging guidelines, up for grabs for any WebView team member.

Comment 5 by ntfschr@chromium.org, May 10 2017 

Related bugs: crbug/546862, crbug/486158

Comment 6 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org

Comment 7 by torne@chromium.org, May 10 2018

Status: WontFix (was: Available)
The webview-specific license checker has been removed.
►

Sign in to add a comment