Help App bug with language support |
|||||||||||||||||
Issue descriptionMigrated from b/31624064 See: https://screenshot.googleplex.com/fswS9Js6FPy.png Two issues which need to be investigated include - 1. Headers in the articles are not properly localized. 2. Left navigation bar does not support the length of the translated topic strings
,
Sep 26 2016
Next steps: - Investigate where the language translation is occurring in the code
,
Sep 26 2016
Not doubting original screenshot, but cannot duplicate. Need more info about issue from reporter. Tested both "Spanish" and "Spanish - Latin America" on the following two machines: ASUS Flip Google Chrome 53.0.2785.129 (Build oficial) beta (32 bits) Revisión 173b700f954facecc7ce070e8acffe9387950200-refs/branch-heads/2785@{#910} Plataforma 8530.90.0 (Official Build) beta-channel veyron_minnie Pixel Google Chrome 54.0.2840.24 (Official Build) beta (64-bit) Revision 0 Platform 8743.25.0 (Official Build) beta-channel link Screenshots attached. Note the differing text lengths in left sidebar for two versions of Spanish.
,
Oct 3 2016
@morsed: I've gone back to the reporter and obtained steps to reproduce (version M53). It looks like this might have something to do with syncing information for languages online given the WiFi step. Here are the steps to reproduce: - Chrome OS is displayed in English. - Login to Chrome OS. - Disable WiFi. - Change language to Spanish. Log out to enable language change. - Login to Chrome OS. - Open help center. This appears to happen when going from ENG to SPA but not the other way around. I tried it by switching from English to German and got a similar problem. Going online and reopening the help center solves the issue.
,
Oct 3 2016
,
Nov 17 2016
Still troubleshooting, but it appears that the wrong field is being called for article titles. It seems that the universal internal article "name" is being called for OFFLINE articles caches in ChromeOS, and that doesn't get translated. Another field, "title" or "web page title" does get translated. Attaching screenshots from gKMS and Redwood for reference.
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/c5eebcf906bfd53517e19f32bcb4a2054383a962 commit c5eebcf906bfd53517e19f32bcb4a2054383a962 Author: David Morse <morsed@google.com> Date: Fri Dec 09 03:37:28 2016
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/c5eebcf906bfd53517e19f32bcb4a2054383a962 commit c5eebcf906bfd53517e19f32bcb4a2054383a962 Author: David Morse <morsed@google.com> Date: Fri Dec 09 03:37:28 2016
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/c5eebcf906bfd53517e19f32bcb4a2054383a962 commit c5eebcf906bfd53517e19f32bcb4a2054383a962 Author: David Morse <morsed@google.com> Date: Fri Dec 09 03:37:28 2016
,
Dec 23 2016
,
Dec 25 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8821b3c672bd60988b4ad6b51e65408cd35a615b commit 8821b3c672bd60988b4ad6b51e65408cd35a615b Author: David Morse <morsed@google.com> Date: Fri Dec 23 02:48:21 2016
,
Dec 27 2016
We have translations now for this bug and crbug.com/666157 . They landed in M57 (9121.0.0/57.0.2962.0), and I'd like to merge them back to M56. No new code. See https://chrome-internal-review.googlesource.com/#/c/314177/
,
Dec 27 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 28 2016
@weifang: This is essentially two different issues. The first is in the process of being fixed. The second requires more thought and should be broken off into it's own ticket if it is to be pursued further. 1. For the record, the solution for these offline article titles was whitelisting the "question" field in google3/googleclient/chrome/chromeos_genius/tools/download_content.py. The call for article JSON had been relying on the "name" field, which is just the name of the article for gKMS content editors, which is always in English and is never translated. "Question" is the translated article title in Support Content API. [Incidentally, when Get Help back-end is migrated to newer API (support.google.com) from the old (googleapis.com), "title" will be the name of article titles, not "question".] 2. Left topic sidebar was built to provide ellipses when topic name was too long to fit the space as originally designed (this does happen in some translations). It is working as intended and is not a bug. Shorter custom translations can be requested from the Translation Console if it is important to find text that does not require truncation, assuming appropriate shorter translations are possible for whichever languages currently require ellipses. Alternately, the app could be redesigned with a wider left topic sidebar, but that would be a larger scope of work: assessing why the currently app widths were chose, discovery on current limitations and options regarding display of ChromeOS apps, tweaking app for new widths, and then thorough testing across a variety of devices.
,
Jan 2 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3 2017
@morsed - Thanks for the details! I will keep #2 in mind as we plan for future Help App updates and log a separate bug as needed.
,
Jan 5 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
1: On Headers in the articles, mergeback to M56 with new translations for titles showed conflicts and would have required manual editing of 100+ files, so mergeback abandoned. It was only a nice to have anyway. 2: Ellipses issue addressed in comment above and should be filed as a separate ticket if an update is desired.
,
Mar 29 2017
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by abodenha@chromium.org
, Sep 20 2016