Issue 648711 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	glevin@chromium.org
Closed:	Oct 2016
Cc:	tbuck...@chromium.org █ sjoe@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Quirks Client should not query the server for display id 0x00000000

Project Member Reported by glevin@chromium.org, Sep 20 2016

Issue description

The Quirks Server appears to be getting a lot of requests for display id 0x00000000.  I assume these come from devices / displays where the display id cannot, for whatever reason, be determined from the EDID.  The Quirks Client should check for this id and immediately abort.  Note that there is no real harm in the current behavior, except for adding a little server load from useless queries.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a081d1219512f55b1adc2636150a6d37b691bb9

commit 8a081d1219512f55b1adc2636150a6d37b691bb9
Author: glevin <glevin@chromium.org>
Date: Fri Sep 30 18:26:52 2016

Don't send Quirks Server requests for product_id = 0

BUG= 648711 
TEST= ??? You'd have to check VLOGs for a device which can't read its
id from its EDID, but we don't know which devices those are.

We're seeing a lot of requests for id = 0.  These are presumably
devices where the manufacturer id and product code (which we roll into
the display product id) couldn't be determined from the EDID.  0 is
a clearly invalid id, so there's no point in sending those requests
to the server.

Review-Url: https://codereview.chromium.org/2365903004
Cr-Commit-Position: refs/heads/master@{#422158}

[modify] https://crrev.com/8a081d1219512f55b1adc2636150a6d37b691bb9/ash/display/display_color_manager_chromeos_unittest.cc
[modify] https://crrev.com/8a081d1219512f55b1adc2636150a6d37b691bb9/components/quirks/quirks_manager.cc