New issue
Advanced search Search tips

Issue 648707 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 667431
issue 690959
issue 696747



Sign in to add a comment

Use GpuMemoryBuffer APIs directly in Blink

Project Member Reported by ccameron@chromium.org, Sep 20 2016

Issue description

We're using GpuMemoryBuffers indirectly through things like glCreateGpuMemoryBufferImageCHROMIUM.

Every time we add a new GpuMemoryBuffer API entrypoint, we have to create a new GL API here.

Instead, let's just use GpuMemoryBuffers directly, and delete these GL APIs.
 
Components: -Blink Blink>Compositing
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c48d1d4786798ab90251e4131a2e808faffe525

commit 9c48d1d4786798ab90251e4131a2e808faffe525
Author: ccameron <ccameron@chromium.org>
Date: Thu Sep 22 01:46:01 2016

Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG= 648707 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2354903003
Cr-Commit-Position: refs/heads/master@{#420232}

[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/android_webview/browser/render_thread_manager.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/output/software_renderer_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/quads/render_pass.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/raster/staging_buffer_pool.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/resources/resource_provider.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/tiles/picture_layer_tiling_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/cc/tiles/tile.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/components/display_compositor/yuv_readback_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/browser/compositor/software_output_device_mac.mm
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/browser/compositor/surface_utils.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/renderer/media/canvas_capture_handler.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/renderer/media/canvas_capture_handler_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/renderer/media/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/gpu/command_buffer/tests/es3_misc_functions_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/gpu/command_buffer/tests/gl_fence_sync_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/gpu/ipc/client/gpu_memory_buffer_impl_test_template.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/base/android/stream_texture_wrapper.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/base/video_util.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/capture/video/file_video_capture_device.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/capture/video/mac/video_capture_device_avfoundation_mac.mm
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/cast/test/utility/barcode.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/cast/test/utility/video_utility.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/cdm/simple_cdm_allocator.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/filters/vpx_video_decoder_fuzzertest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/gpu/media_foundation_video_encode_accelerator_win.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/gpu/vt_video_encode_accelerator_mac.h
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/mojo/common/mojo_shared_buffer_video_frame_unittest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/mojo/services/mojo_cdm_allocator.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/muxers/webm_muxer.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/muxers/webm_muxer_fuzzertest.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/ui/gfx/BUILD.gn
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/ui/gfx/gpu_memory_buffer.cc
[modify] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/ui/gfx/gpu_memory_buffer.h
[add] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/ui/gfx/gpu_memory_buffer_tracing.cc
[add] https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525/ui/gfx/gpu_memory_buffer_tracing.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ba2258a4d613f70ab966f52249209d6156136cd

commit 0ba2258a4d613f70ab966f52249209d6156136cd
Author: ccameron <ccameron@chromium.org>
Date: Thu Oct 06 19:36:35 2016

DrawingBuffer cleanup: Part 1 of many

DrawingBuffer is actually a buffer queue that recycles buffers.

This buffer queue shrinks the recycle queue when it is asked to
pull an element from the recycle queue. It makes more sense to
do this when the elements are put in the recycle queue.

The buffer queue also has a function to resize a recycled
buffer, instead of just deleting it and creating a new one (perhaps
under the idea the creating and destroying GL texture names
is expensive). Remove this functionality because it just complicates
things.

While we're in the neighborhood, inline the resize functions for
the multisample and depth and stencil functions (there's no point
to having a short helper function that is called in only one place,
it gives a feeling of more generality than actually exists).

BUG= 648707 

Review-Url: https://codereview.chromium.org/2399733002
Cr-Commit-Position: refs/heads/master@{#423631}

[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57351f256cfe16ba1718a9a2f3c1ef8c58dceda4

commit 57351f256cfe16ba1718a9a2f3c1ef8c58dceda4
Author: ccameron <ccameron@chromium.org>
Date: Fri Oct 07 22:18:04 2016

DrawingBuffer cleanup: Merge structures

There exist four related structures for storing color textures:
TextureInfo, MailboxInfo, RecycledMailbox, and FrontBufferInfo. Merge
all of these into one structure, called ColorBuffer.

Make ColorBuffer be a refcounted structure.

Make the destructor of ColorBuffer destroy the GL resources. Delete all
of the various helper functions and calls that existed to destroy GL
resources.

There are many instances where we look up a MailboxInfo in
m_textureMailboxes via its gpu::Mailbox. Change all of these instances
to just point to the same structure.

BUG= 648707 

Review-Url: https://codereview.chromium.org/2401513002
Cr-Commit-Position: refs/heads/master@{#423983}

[modify] https://crrev.com/57351f256cfe16ba1718a9a2f3c1ef8c58dceda4/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/57351f256cfe16ba1718a9a2f3c1ef8c58dceda4/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b7a69f6544da9a4b1fa4c0719e814269115acbd

commit 8b7a69f6544da9a4b1fa4c0719e814269115acbd
Author: ccameron <ccameron@chromium.org>
Date: Fri Oct 07 23:17:36 2016

DrawingBuffer clean-up: Aesthetic changes

Rename several variables to reflect that they are based on ColorBuffers.

Re-organize createColorBuffer to be in a single function with multiple
steps, rather than several functions that call each other.

Re-organize prepareTextureMailboxInternal to branch off into separate
gpu and software implementations.

This patch should have no functional effect.

BUG= 648707 

Review-Url: https://codereview.chromium.org/2397713005
Cr-Commit-Position: refs/heads/master@{#424006}

[modify] https://crrev.com/8b7a69f6544da9a4b1fa4c0719e814269115acbd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/8b7a69f6544da9a4b1fa4c0719e814269115acbd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/123016bf9ed08d599540dddc9a3b92a0df7eba2e

commit 123016bf9ed08d599540dddc9a3b92a0df7eba2e
Author: ccameron <ccameron@chromium.org>
Date: Fri Oct 21 02:05:50 2016

DrawingBuffer: Clean up GL state restoration

Several of DrawingBuffer's methods leave the caller's state dirty,
and the responsibility for restoring this state comes in three forms:
- Responsibility of DrawingBuffer.
  - E.g, DrawingBuffer::PrepareTextureMailbox, which calls
    DrawingBuffer::finishPrepareTextureMailboxGpu, which restores
    texture and framebuffer bindings.
- Responsibility of the caller
  - E.g, WebGLRenderingContextBase::restoreStateAfterClear and
    everything that calls it.
  - Except..
- Both, together, in strange ways. That is, the caller will explicitly
  restore some state, but it will also call into DrawingBuffer to
  restore some of the state
  - E.g, WebGLRenderingContextBase::reshape, where we have all
    sorts of state restore calls, from all sorts of places.

Note how strange it is to have WebGLRenderingContextBase call
DrawingBuffer to have it restore state. WebGLRenderingContextBase is
the structure that knows the values to restore -- DrawingBuffer only
knows these values because WebGLRenderingContextBase told them to it.

Get rid of all of the state tracking in DrawingBuffer. Instead, have
it call back to its Client (WebGLRenderingContextBase) to restore state
at the end of all of its public entrypoints.

There exists no testing for this state restoration. Sprinkle "verify
that state was restored correctly" calls throughout the existing tests.

Also, make some method names more sensical. Change "commit" to a
name that reflects what it does and the state changes associated with it.
Change "reset" to "resize".

BUG= 648707 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2402273002
Cr-Commit-Position: refs/heads/master@{#426686}

[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/123016bf9ed08d599540dddc9a3b92a0df7eba2e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ba2258a4d613f70ab966f52249209d6156136cd

commit 0ba2258a4d613f70ab966f52249209d6156136cd
Author: ccameron <ccameron@chromium.org>
Date: Thu Oct 06 19:36:35 2016

DrawingBuffer cleanup: Part 1 of many

DrawingBuffer is actually a buffer queue that recycles buffers.

This buffer queue shrinks the recycle queue when it is asked to
pull an element from the recycle queue. It makes more sense to
do this when the elements are put in the recycle queue.

The buffer queue also has a function to resize a recycled
buffer, instead of just deleting it and creating a new one (perhaps
under the idea the creating and destroying GL texture names
is expensive). Remove this functionality because it just complicates
things.

While we're in the neighborhood, inline the resize functions for
the multisample and depth and stencil functions (there's no point
to having a short helper function that is called in only one place,
it gives a feeling of more generality than actually exists).

BUG= 648707 

Review-Url: https://codereview.chromium.org/2399733002
Cr-Commit-Position: refs/heads/master@{#423631}

[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[modify] https://crrev.com/0ba2258a4d613f70ab966f52249209d6156136cd/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Blocking: -44872 667431
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8cf426b59b931395bfe5114c7c6952473f210ce

commit b8cf426b59b931395bfe5114c7c6952473f210ce
Author: ccameron <ccameron@chromium.org>
Date: Wed Jan 25 23:09:29 2017

DrawingBuffer: Use gfx::GpuMemoryBuffer directly and set color space

With this instance remove, we no longer have any non-test callers of
CreateGpuMemoryBufferImageCHROMIUM.

Set the TextureMailbox color space for the DrawingBuffer. This
parameter is ignored except when --enable-color-correct-rendering is
used (further in the compositing pipeline).

Set the scanout color space for the DrawingBuffer, but only when
--enable-color-correct-rendering is used (because that function
goes directly to the underlying IOSurface).

BUG= 648707 
TBR=kbr

Review-Url: https://codereview.chromium.org/2643343002
Cr-Commit-Position: refs/heads/master@{#446156}

[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/b8cf426b59b931395bfe5114c7c6952473f210ce/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a432af1882f7097be6b332b9e8186f8bc98fb279

commit a432af1882f7097be6b332b9e8186f8bc98fb279
Author: ccameron <ccameron@chromium.org>
Date: Wed Feb 08 05:12:49 2017

Remove remaining traces of CreateGpuMemoryBufferImageCHROMIUM

We use the GpuMemoryBuffer API directly, making this redundant.

R=zmo,sandersd
TBR=bbudge,pdr (OWNERs mechanical change paths)
BUG= 648707 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2648893002
Cr-Commit-Position: refs/heads/master@{#448911}

[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/cc/test/test_gles2_interface.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/cc/test/test_gles2_interface.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/components/display_compositor/buffer_queue.h
[delete] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_420v_image.txt
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycbcr_422_image.txt
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_ycrcb_420_image.txt
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/GLES2/gl2extchromium.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/client_test_helper.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_implementation_unittest.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/client/gpu_control.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/common/gles2_cmd_utils_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/common/gpu_memory_buffer_support.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/service/gles2_cmd_validation_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/tests/gl_copy_tex_image_2d_workaround_unittest.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/gles2_conform_support/egl/context.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/media/renderers/video_overlay_factory.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/ppapi/proxy/ppapi_command_buffer_proxy.cc
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/ppapi/proxy/ppapi_command_buffer_proxy.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/third_party/WebKit/Source/platform/graphics/GraphicsTypes3D.h
[modify] https://crrev.com/a432af1882f7097be6b332b9e8186f8bc98fb279/ui/gl/gl_bindings.h

Status: Fixed (was: Started)
With #11, there is no other way to use GMBs.

Comment 13 by kbr@chromium.org, Feb 10 2017

Blocking: 690959
Blocking: 696747

Sign in to add a comment