The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/260ea4c5badff5adfd768dd6d51085d78c239885

commit 260ea4c5badff5adfd768dd6d51085d78c239885
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Sep 20 21:53:10 2016

[Sync] Restructure ModelTypeWorkerTest to match SMTP test.

- Move function definitions inside the class declaration.
- Move static functions to an anonymous namespace.
- Introduce kTagN, kValueN, and kHashN constants.
- Remove 14 methods that were simply forwards to calls on the processor
  or server and add direct accessors to those classes instead.

BUG= 648705 

Review-Url: https://codereview.chromium.org/2355993002
Cr-Commit-Position: refs/heads/master@{#419861}

[modify] https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885/components/sync/test/engine/mock_model_type_processor.cc
[modify] https://crrev.com/260ea4c5badff5adfd768dd6d51085d78c239885/components/sync/test/engine/mock_model_type_processor.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/624769f8846b21df41108794722d21aa9f82e2fa

commit 624769f8846b21df41108794722d21aa9f82e2fa
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Sep 22 20:42:32 2016

[Sync] Misc ModelTypeWorker improvements.

- Remove IsEncryptionRequired and just use cryptographer_ instead.
- Use ThreadChecker instead of NonThreadSafe.
- Tweak some comments.
- Simplify (without changing) the encryption handling logic in
  ProcessGetUpdatesResponse.
- Make DecryptSpecifics not static so the cryptographer doesn't need to
  be passed in.

BUG= 648705 

Review-Url: https://codereview.chromium.org/2353353004
Cr-Commit-Position: refs/heads/master@{#420449}

[modify] https://crrev.com/624769f8846b21df41108794722d21aa9f82e2fa/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/624769f8846b21df41108794722d21aa9f82e2fa/components/sync/engine_impl/model_type_worker.h

ModelTypeWorker was simplified recently and can be simplified even more. After these changes are done we need to reassess test coverage from model_type_worker_unittest.cc.

Assigning to mamir@ who is actively contributing in this area, to eventually pick this up.

Triage ping: Any updates? Is there anything left to be done here?

sync-triage ping: any updates?

sync-triage-ping, any updates?

This isn't time critical for now so changing to P3.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9508bd7fec86a806dd055014235ec5bad6a96dc7

commit 9508bd7fec86a806dd055014235ec5bad6a96dc7
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Nov 19 15:58:19 2018

[Sync::USS] Remove irrelevant tests from ModelTypeWorker unit test

Some tests in ModelTypeWorkerTest are testing the behavior of the
worker across restarts. This functionality isn't implemented in the
production code. In addition, the data aren't wired in the test, and
obviously test expectations are commented out.

This CL is cleaning this up and removing those test and associated
plumbing code.

Bug:  648705 
Change-Id: I6139ae531256ed2873244a07fdbdde5a2e511c04
Reviewed-on: https://chromium-review.googlesource.com/c/1341920
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609314}
[modify] https://crrev.com/9508bd7fec86a806dd055014235ec5bad6a96dc7/components/sync/engine_impl/model_type_worker_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8397534646ab95fd7586a1cf3773b4609e559b8

commit a8397534646ab95fd7586a1cf3773b4609e559b8
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Nov 19 17:08:54 2018

[Sync::USS] Test that worker waits till the decryption key is available

Worker keeps encrypted entities until the decryption key is available.
Two tests are added to test verify this behavior.

Bug:  648705 
Change-Id: I7e60fdc980eb72601864b98499590d4aae190d50
Reviewed-on: https://chromium-review.googlesource.com/c/1341847
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609336}
[modify] https://crrev.com/a8397534646ab95fd7586a1cf3773b4609e559b8/components/sync/engine_impl/model_type_worker_unittest.cc

According the test coverage tool, no need more work is needed here.
Consequently, closing as fixed.