Improve caption button in video player |
||||
Issue descriptionCurrently, if the publisher does not provide a label to identify a track, the player will display "Unknown" and "Off" as the available tracks when the user selects the CC button. After discussion with UX, the video player should be changed as follows: 1. If there is only one caption or subtitle track, the CC button should act as a toggle (on/off). The button graphic already indicates the On/Off state. 2. If there are multiple tracks, the CC button should display a list, and: a. use the developer provided label for each track where available (existing behavior); b. otherwise, use the developer provided language tag if available; c. otherwise, display "Track 1", "Track 2" (instead of "Unknown") Note that tracks (or 'label' properties) may be added or removed at any time through JS, and the UI should keep in sync as changes are made. Eng owner: mlamouri@ Product owner: johnpallett@
,
Oct 4 2016
,
Oct 25 2016
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480c4553694769458606f287350d13ff144a05e6 commit 480c4553694769458606f287350d13ff144a05e6 Author: finnur <finnur@chromium.org> Date: Tue Nov 01 17:52:59 2016 Improve caption button behavior for video player. - If there is only one caption, the CC button should just toggle it on and off. - If the track has no label, instead of showing Unknown, it should show the language label and if that is also empty, it should show Track X. BUG= 648696 Review-Url: https://codereview.chromium.org/2456993003 Cr-Commit-Position: refs/heads/master@{#429044} [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/content/app/strings/content_strings.grd [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/media-controls.js [add] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/video-controls-caption-single-track.html [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/video-controls-captions.html [add] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/video-controls-labels.html [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-closed-captions-button.html [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp [modify] https://crrev.com/480c4553694769458606f287350d13ff144a05e6/third_party/WebKit/Source/core/html/shadow/MediaControls.h
,
Nov 1 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mlamouri@chromium.org
, Sep 21 2016Components: -Blink>Media>Video Blink>Media>Controls
Labels: -OS-Android -OS-Windows -OS-Chrome -OS-Mac OS-All
Owner: ----
Status: Available (was: Untriaged)