Issue 648686 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	pmonette@chromium.org
Cc:	ew...@chromium.org
Components:	UI>Browser>FirstRun
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	2
Type:	Feature
Hotlist-Merge-Review M-56 merge-merged-2924

Blocked on:
issue 685799

Implement new FRE on Win 10

Project Member Reported by tmartino@chromium.org, Sep 20 2016

Issue description

go/chrome-desktop-fre-dd

We are redesigning the first-run/onboarding experience for Chrome Desktop; Win 10 has a dedicated flow that is implemented separately from other platforms. This bug tracks eng efforts.

Comment 1 by ew...@chromium.org, Sep 20 2016

Main launch bug: Issue 608875

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24dfd18e12d406910b81fe04110cc6335b5ba91a

commit 24dfd18e12d406910b81fe04110cc6335b5ba91a
Author: tmartino <tmartino@chromium.org>
Date: Fri Sep 23 18:23:18 2016

Adding strings for forthcoming Win 10 welcome page.

BUG=648686

Review-Url: https://codereview.chromium.org/2364683002
Cr-Commit-Position: refs/heads/master@{#420668}

[modify] https://crrev.com/24dfd18e12d406910b81fe04110cc6335b5ba91a/chrome/app/chromium_strings.grd
[modify] https://crrev.com/24dfd18e12d406910b81fe04110cc6335b5ba91a/chrome/app/generated_resources.grd
[modify] https://crrev.com/24dfd18e12d406910b81fe04110cc6335b5ba91a/chrome/app/google_chrome_strings.grd

Comment 3 by tmartino@chromium.org, Oct 7 2016

Owner: pmonette@chromium.org

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218e0aa27614cab0d01aa72f01cbb33d853a500d

commit 218e0aa27614cab0d01aa72f01cbb33d853a500d
Author: pmonette <pmonette@chromium.org>
Date: Tue Oct 25 03:26:47 2016

Adding client code for new Windows 10 First Run Experience

BUG=648686
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2401853005
Cr-Commit-Position: refs/heads/master@{#427263}

[modify] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/browser_resources.grd
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/README.md
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/inline.css
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/inline.html
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/inline.js
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/sectioned.css
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/sectioned.html
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/resources/welcome/win10/sectioned.js
[modify] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/webui/welcome_win10_handler.cc
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/webui/welcome_win10_handler.h
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/webui/welcome_win10_ui.cc
[add] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/browser/ui/webui/welcome_win10_ui.h
[modify] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/common/url_constants.cc
[modify] https://crrev.com/218e0aa27614cab0d01aa72f01cbb33d853a500d/chrome/common/url_constants.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083

commit b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083
Author: pmonette <pmonette@chromium.org>
Date: Wed Nov 09 00:32:45 2016

Determine the Win10-specific Welcome page variant to display

An asynchronous check to determine Chrome's pinned state is done in order
to decide if the "Pin Chrome to taskbar" instructions should be displayed.

BUG=648686
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2449853008
Cr-Commit-Position: refs/heads/master@{#430793}

[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/resources/welcome/win10/inline.js
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/resources/welcome/win10/sectioned.js
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/ui/startup/startup_features.cc
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/ui/startup/startup_features.h
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/ui/webui/welcome_win10_handler.cc
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/ui/webui/welcome_win10_handler.h
[modify] https://crrev.com/b9f756c3b1853a17cd4cfbfcb003f52bd2ae8083/chrome/browser/ui/webui/welcome_win10_ui.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444ce88afe130945dae057125d706b789da9282d

commit 444ce88afe130945dae057125d706b789da9282d
Author: pmonette <pmonette@chromium.org>
Date: Fri Nov 25 21:18:37 2016

Adding metrics on the usefulness of the Win10 version of the Welcome Page

Records an histogram value that indicates if the instructions helped the
user change their default browser and/or pin Chrome to the taskbar.

BUG=648686

Review-Url: https://codereview.chromium.org/2513953004
Cr-Commit-Position: refs/heads/master@{#434550}

[modify] https://crrev.com/444ce88afe130945dae057125d706b789da9282d/chrome/browser/ui/webui/welcome_win10_handler.cc
[modify] https://crrev.com/444ce88afe130945dae057125d706b789da9282d/chrome/browser/ui/webui/welcome_win10_handler.h
[modify] https://crrev.com/444ce88afe130945dae057125d706b789da9282d/chrome/browser/ui/webui/welcome_win10_ui.cc
[modify] https://crrev.com/444ce88afe130945dae057125d706b789da9282d/tools/metrics/actions/actions.xml
[modify] https://crrev.com/444ce88afe130945dae057125d706b789da9282d/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab0bd29c2204b4c28d4aef9024bd44074710eb76

commit ab0bd29c2204b4c28d4aef9024bd44074710eb76
Author: pmonette <pmonette@chromium.org>
Date: Fri Dec 16 23:55:42 2016

Implement Win 10 onboarding content logic

The onboarding content is a set of startup promo pages that are shown at
most once to the user.

Also adds a pref to remember if the Win10 promo page has been seen.

BUG=648686

Review-Url: https://codereview.chromium.org/2578843002
Cr-Commit-Position: refs/heads/master@{#439236}

[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/browser/ui/webui/welcome_win10_ui.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/common/pref_names.cc
[modify] https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76/chrome/common/pref_names.h

Comment 8 by tmartino@chromium.org, Jan 10 2017

Labels: -M-55 M-56 Merge-Request-56

Requesting merge of crrev.com/2513953004 and crrev.com/2578843002

Both fixes verified in Canary.

Project Member

Comment 9 by sheriffbot@chromium.org, Jan 10 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review

This bug requires manual review: There is .grd file changes and we are only 20 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by tmartino@chromium.org, Jan 10 2017

Note to owners: .grd changes are a false positive; it is only the last two CLs that are Merge Requested.

Comment 11 by bustamante@google.com, Jan 10 2017

Labels: -Merge-Review-56 Merge-Approved-56

Approving for merge into M56

Comment 12 by ligim...@chromium.org, Jan 12 2017

Your change has been approved for M56, please merge ASAP .

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

Labels: -merge-approved-56 merge-merged-2924

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/511870edeca2bb6b9b2adf04836a017e7569cdc6

commit 511870edeca2bb6b9b2adf04836a017e7569cdc6
Author: tmartino <tmartino@chromium.org>
Date: Fri Jan 13 21:50:48 2017

Adding metrics on the usefulness of the Win10 version of the Welcome Page

Records an histogram value that indicates if the instructions helped the
user change their default browser and/or pin Chrome to the taskbar.

BUG=648686

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2513953004
Cr-Commit-Position: refs/heads/master@{#434550}
(cherry picked from commit 444ce88afe130945dae057125d706b789da9282d)

Review-Url: https://codereview.chromium.org/2629883005
Cr-Commit-Position: refs/branch-heads/2924@{#764}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/511870edeca2bb6b9b2adf04836a017e7569cdc6/chrome/browser/ui/webui/welcome_win10_handler.cc
[modify] https://crrev.com/511870edeca2bb6b9b2adf04836a017e7569cdc6/chrome/browser/ui/webui/welcome_win10_handler.h
[modify] https://crrev.com/511870edeca2bb6b9b2adf04836a017e7569cdc6/chrome/browser/ui/webui/welcome_win10_ui.cc
[modify] https://crrev.com/511870edeca2bb6b9b2adf04836a017e7569cdc6/tools/metrics/actions/actions.xml
[modify] https://crrev.com/511870edeca2bb6b9b2adf04836a017e7569cdc6/tools/metrics/histograms/histograms.xml

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61b53645e5a7503f03e0cf66870cd936176c0d99

commit 61b53645e5a7503f03e0cf66870cd936176c0d99
Author: tmartino <tmartino@chromium.org>
Date: Mon Jan 16 16:32:53 2017

Implement Win 10 onboarding content logic

The onboarding content is a set of startup promo pages that are shown at
most once to the user.

Also adds a pref to remember if the Win10 promo page has been seen.

BUG=648686
NOTRY=true
NOPRESUBMIT=true
TBR=pmonette@chromium.org

Review-Url: https://codereview.chromium.org/2578843002
Cr-Commit-Position: refs/heads/master@{#439236}
(cherry picked from commit ab0bd29c2204b4c28d4aef9024bd44074710eb76)

Review-Url: https://codereview.chromium.org/2635773003
Cr-Commit-Position: refs/branch-heads/2924@{#773}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/browser/ui/webui/welcome_win10_ui.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/common/pref_names.cc
[modify] https://crrev.com/61b53645e5a7503f03e0cf66870cd936176c0d99/chrome/common/pref_names.h

Comment 15 by pmonette@chromium.org, Jan 26 2017

Blockedon: 685799

►

Issue 648686 link

Issue metadata

Implement new FRE on Win 10

Issue description

Comment 1 by ew...@chromium.org, Sep 20 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 23 2016

Comment 2 Deleted

Comment 3 by tmartino@chromium.org, Oct 7 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 25 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Nov 25 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 17 2016

Comment 7 Deleted

Comment 8 by tmartino@chromium.org, Jan 10 2017

Comment 8 Deleted

Comment 9 by sheriffbot@chromium.org, Jan 10 2017

Comment 9 Deleted

Comment 10 by tmartino@chromium.org, Jan 10 2017

Comment 10 Deleted

Comment 11 by bustamante@google.com, Jan 10 2017

Comment 11 Deleted

Comment 12 by ligim...@chromium.org, Jan 12 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jan 16 2017

Comment 14 Deleted

Comment 15 by pmonette@chromium.org, Jan 26 2017

Comment 15 Deleted

Sign in to add a comment