New issue
Advanced search Search tips

Issue 648670 link

Starred by 1 user
Status: Fixed
Owner:
lambroslambrou@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Android][Host] Decide what to do with the CRD Android Host Code

Project Member Reported by joedow@chromium.org, Sep 20 2016 
I recently made a change to It2Me which technically affected the android host but no one thought the host was being built.  My change passed through the trybots and then caused a failure on the real waterfalls because there was a target which built the host for some reason.

I think we should either keep the host and add the target to our set of base android targets (so trybots and local builds will fail correctly) or remove the code.

I think it would be good for the triage team to chat about this and make the call.

Comment 1 by jamiewa...@chromium.org, Sep 20 2016

Owner: lambroslambrou@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/429625d84b4d1f3073d4a1535530279436f8e790

commit 429625d84b4d1f3073d4a1535530279436f8e790
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Thu Sep 22 22:00:53 2016

[remoting android] Remove host It2Me implementation.

For the record, in case we decide to bring this back, there is also an
un-landed CL at
https://codereview.chromium.org/1917063002/

BUG= 648670 

Review-Url: https://codereview.chromium.org/2358083003
Cr-Commit-Position: refs/heads/master@{#420473}

[modify] https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790/remoting/android/BUILD.gn
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/AndroidManifest.xml
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/res/layout/main.xml
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeHostObserver.java
[modify] https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790/remoting/host/BUILD.gn
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/DEPS
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/jni_host.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/jni_host.h
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/remoting_host_jni_onload.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/remoting_host_jni_registrar.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/android/remoting_host_jni_registrar.h
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/audio_capturer_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/continue_window_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/curtain_mode_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/desktop_resizer_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/disconnect_window_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/input_injector_android.cc
[modify] https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790/remoting/host/it2me/BUILD.gn
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/it2me/it2me_confirmation_dialog_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/local_input_monitor_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/pairing_registry_delegate_android.cc
[delete] https://crrev.com/f29b3424711e7a435c904705e9e5865603a67c09/remoting/host/resources_android.cc
[modify] https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790/remoting/remoting_enable.gni

Comment 3 by lambroslambrou@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment