histograms.xml is too big |
||
Issue descriptionhistograms.xml has grown to a size that: 1. It takes longer than the "renderer is hung" seconds to load in code search, so I get the "your renderer is hung" dialog. (see attached image). 2. You cannot view the diff in code reviews, making code reviews harder. I wonder if we could consider either: 1. Splitting histograms.xml into smaller files somehow. Perhaps the pretty_print.py script could handle all this automatically? 2. Making code search handle large files better 4. Making code review handle large files better Putting in Metrics component but if we decide we cannot change histograms.xml then I'll assign to infra to look at.
,
Sep 21 2016
Arguably, we should be able to remove all obsolete entries in the file, without affecting what our dashboards can show. Probably we'd achieve this by keeping some master file checked into google3, which has better support for large files than the Chromium repo.
,
Sep 21 2016
Thanks for the links to those other issues. it sounds like many of the issues will be fixed with gerrit, and the codesearch issue can be worked around by just viewing histograms.xml in internal codesearch? I agree maybe removing the obsolete histograms from the copy in chromium, if there is some way of making sure they stick around in the internal histograms.xml. I'm happy to close this as WontFix. Thanks. (feel free to reopen if you still want to track it). |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Sep 21 2016