New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648638 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 162819
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

add cq? equivalent to codereview tool

Project Member Reported by ojan@chromium.org, Sep 20 2016

Issue description

In WebKit, you could put cq+ to put something in the cq. cq- to tell people not to put things in the cq (e.g. because you know it depends on another patch). And cq? to tell others to put it in the cq if they believe it's ready (typically this would be the reviewe).

Being able to express that intent comes up frequently. Can we add something like that to polygerrit?
 
When you say “put cq+”, what exactly do you mean? Put it where?
Cc: jochen@chromium.org
+jochen@ this isn't exactly what you've explained and asked for before, but I think you'd be interested.
There'll need to some sort of guard against the combination of "cq+" and "lgtm with nits" to make sure the author gets a chance to fix the nits.

Comment 4 by jochen@chromium.org, Sep 20 2016

This is more or less exactly what I asked for in https://bugs.chromium.org/p/chromium/issues/detail?id=162819
Labels: -Proj-Gerrit-Migration
Status: Available (was: Untriaged)
Mergedinto: 162819
Status: Duplicate (was: Available)

Sign in to add a comment