PlzNavigate: properly set origin and referrer header |
|||||
Issue descriptionThey are not always set correctly. See the layout test http/tests/navigation/post-frames-goback1.html for example.
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d060a7060e9085b64eda7c3e617e2f708fb4411 commit 3d060a7060e9085b64eda7c3e617e2f708fb4411 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Nov 14 18:30:34 2016 PlzNavigate:Add missing Upgrade-Insecure-Requests header. The Upgrade-Insecure-Requests header was missing for browser-initiated navigation requests. A test showing this lack was added with this bugfix. It **partially** fixes the following tests too: * http/tests/navigation/post-frames-goback1.html * http/tests/navigation/post-goback1.html * virtual/stable/http/tests/navigation/post-frames-goback1.html * virtual/stable/http/tests/navigation/post-goback1.html with --enable-browser-side-navigation flag. BUG= 648588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2462513003 Cr-Commit-Position: refs/heads/master@{#431877} [modify] https://crrev.com/3d060a7060e9085b64eda7c3e617e2f708fb4411/content/browser/frame_host/navigation_request.cc [add] https://crrev.com/3d060a7060e9085b64eda7c3e617e2f708fb4411/third_party/WebKit/LayoutTests/http/tests/security/upgrade-insecure-requests/https-header-top-level-browser-initiated.php
,
Dec 6 2016
,
Dec 6 2016
Should this be assigned to Arthur?
,
Dec 6 2016
I have a patch in review for the origin header at https://codereview.chromium.org/2496293003/ so assigning to myself.
,
Dec 6 2016
There were tree headers missing: * referrer * upgrade-insecure-request * origin Now, it remains only the origin header and it will be fixed by Camille's patch.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce1a32c1989a041c641d2a630362177dffaf14de commit ce1a32c1989a041c641d2a630362177dffaf14de Author: clamy <clamy@chromium.org> Date: Fri Dec 09 21:31:22 2016 PlzNavigate: add origin header This CL ensures the origin header is properly set when using browser-side navigation. BUG= 648588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2496293003 Cr-Commit-Position: refs/heads/master@{#437662} [modify] https://crrev.com/ce1a32c1989a041c641d2a630362177dffaf14de/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/ce1a32c1989a041c641d2a630362177dffaf14de/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
,
Dec 12 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 25 2016