New issue
Advanced search Search tips

Issue 648588 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

PlzNavigate: properly set origin and referrer header

Project Member Reported by clamy@chromium.org, Sep 20 2016

Issue description

They are not always set correctly. See the layout test http/tests/navigation/post-frames-goback1.html for example.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cb7d05bc2e30d147c38ba73e9697f4559e55c0f

commit 4cb7d05bc2e30d147c38ba73e9697f4559e55c0f
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Tue Oct 25 10:54:11 2016

PlzNavigate: Transmit referrer into FrameNavigationEntry.

Referrer information was lost for a subframe navigation. Consequently,
it was not stored in a FrameNavigationEntry and not properly restored
when the user come back to the main page using the back button.

This CL **partially** fixes the tests:
 * http/tests/navigation/post-frame-goback1.html
 * virtual/stable/http/tests/navigation/post-frames-goback1.html
with --enable-browser-side-navigation flag.

BUG= 648588 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2433743004
Cr-Commit-Position: refs/heads/master@{#427314}

[modify] https://crrev.com/4cb7d05bc2e30d147c38ba73e9697f4559e55c0f/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/4cb7d05bc2e30d147c38ba73e9697f4559e55c0f/content/renderer/render_frame_impl.cc
[add] https://crrev.com/4cb7d05bc2e30d147c38ba73e9697f4559e55c0f/content/test/data/navigation_controller/page_with_iframe_simple.html

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d060a7060e9085b64eda7c3e617e2f708fb4411

commit 3d060a7060e9085b64eda7c3e617e2f708fb4411
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon Nov 14 18:30:34 2016

PlzNavigate:Add missing Upgrade-Insecure-Requests header.

The Upgrade-Insecure-Requests header was missing for browser-initiated navigation requests.

A test showing this lack was added with this bugfix.

It **partially** fixes the following tests too:
 * http/tests/navigation/post-frames-goback1.html
 * http/tests/navigation/post-goback1.html
 * virtual/stable/http/tests/navigation/post-frames-goback1.html
 * virtual/stable/http/tests/navigation/post-goback1.html
with --enable-browser-side-navigation flag.

BUG= 648588 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2462513003
Cr-Commit-Position: refs/heads/master@{#431877}

[modify] https://crrev.com/3d060a7060e9085b64eda7c3e617e2f708fb4411/content/browser/frame_host/navigation_request.cc
[add] https://crrev.com/3d060a7060e9085b64eda7c3e617e2f708fb4411/third_party/WebKit/LayoutTests/http/tests/security/upgrade-insecure-requests/https-header-top-level-browser-initiated.php

Comment 3 by clamy@chromium.org, Dec 6 2016

Labels: Proj-PlzNavigate-Blocking

Comment 4 by jam@chromium.org, Dec 6 2016

Cc: arthurso...@chromium.org
Should this be assigned to Arthur?

Comment 5 by clamy@chromium.org, Dec 6 2016

Owner: clamy@chromium.org
Status: Assigned (was: Available)
I have a patch in review for the origin header at https://codereview.chromium.org/2496293003/ so assigning to myself.
There were tree headers missing:
* referrer
* upgrade-insecure-request
* origin

Now, it remains only the origin header and it will be fixed by Camille's patch.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce1a32c1989a041c641d2a630362177dffaf14de

commit ce1a32c1989a041c641d2a630362177dffaf14de
Author: clamy <clamy@chromium.org>
Date: Fri Dec 09 21:31:22 2016

PlzNavigate: add origin header

This CL ensures the origin header is properly set when using
browser-side navigation.

BUG= 648588 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2496293003
Cr-Commit-Position: refs/heads/master@{#437662}

[modify] https://crrev.com/ce1a32c1989a041c641d2a630362177dffaf14de/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/ce1a32c1989a041c641d2a630362177dffaf14de/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Comment 8 by clamy@chromium.org, Dec 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment