ClangToTAndroidASan fails to run base_unittests |
|||
Issue descriptionStarted here: https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/4029 Likely due to an asan runtime change, filed https://llvm.org/bugs/show_bug.cgi?id=30462 This blocks clang rolls past r281909
,
Sep 20 2016
From asan_mapping.h:
=====================================
#if SANITIZER_WORDSIZE == 32
# if SANITIZER_ANDROID
# define SHADOW_OFFSET (0) <<---- HERE
# elif defined(__mips__)
Shadow address on android is 0.
From asan_rtl.c:
=====================================
if (shadow_start == 0) {
[...]
shadow_start = FindAvailableMemoryRange(space_size, alignment, granularity);
}
We assumed that 0 is dynamic address.
On windows, the address was determined with:
# elif SANITIZER_WINDOWS64
# define SHADOW_OFFSET __asan_shadow_memory_dynamic_address
# else
and __asan_shadow_memory_dynamic_address is initially zero.
,
Sep 20 2016
,
Sep 21 2016
,
Sep 21 2016
This is now blocking the current clang roll. (I had to revert the roll I did yesterday.)
,
Sep 21 2016
r282085 should fix
,
Sep 21 2016
Actually, turns out that 32-bit dynamic asan was broken by that change too. I reverted it all in 282097 / 282096. What's scary is that the 32-bit dynamic asan tests weren't hooked up to `ninja check-all`, so the upload bot thought that all was fine :-( (but the 32-bit chrome tot component bot was red, at least). So this is fixed for now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by etienneb@chromium.org
, Sep 20 2016