New issue
Advanced search Search tips

Issue 648578 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 882937
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 882937



Sign in to add a comment

"DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 20 2016

Issue description

"DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhEaXN0aWxsZXJQYWdlV2ViQ29udGVudHNUZXN0LlVzaW5nQ3VycmVudFdlYkNvbnRlbnRzUmVhZHlGb3JEaXN0aWxsYXRpb24M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 620589 .
 

Comment 1 by hbos@chromium.org, Sep 20 2016

Labels: -Sheriff-Chromium
Owner: nyquist@chromium.org
Status: Assigned (was: Untriaged)
nyquist can you take a look? Flaky test, I disabled it.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9356902e22a7dfd4e012143841d6ebea91e14741

commit 9356902e22a7dfd4e012143841d6ebea91e14741
Author: hbos <hbos@chromium.org>
Date: Tue Sep 20 13:47:29 2016

Disabled flaky DistillerPageWebContentsTest tests.

Disabled:
- DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation
- DistillerPageWebContentsTest.UsingCurrentWebContentsNotFinishedLoadingYet

BUG= 648578 
NOTRY=True
TBR=nyquist@chromium.org

Review-Url: https://codereview.chromium.org/2353003002
Cr-Commit-Position: refs/heads/master@{#419742}

[modify] https://crrev.com/9356902e22a7dfd4e012143841d6ebea91e14741/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc

Owner: wychen@chromium.org
wychen: Care to take a look?
Thanks for letting me know.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c1ee98009fbb02721a02ee2f376183d9c023fe

commit 42c1ee98009fbb02721a02ee2f376183d9c023fe
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jul 17 18:51:31 2017

Enable all DistillerPageWebContentsTest tests

Enabled:
- DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation
- DistillerPageWebContentsTest.UsingCurrentWebContentsNotFinishedLoadingYet

These tests were reported flaky, but couldn't repro locally. Re-enable
to get more info on bots.

BUG= 648578 

Change-Id: Ifee5adf4fded7d549d8480d5148c603c45319fe3
Reviewed-on: https://chromium-review.googlesource.com/566591
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487178}
[modify] https://crrev.com/42c1ee98009fbb02721a02ee2f376183d9c023fe/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc

Components: Tests>Disabled
Labels: Test-Disabled
Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhEaXN0aWxsZXJQYWdlV2ViQ29udGVudHNUZXN0LlVzaW5nQ3VycmVudFdlYkNvbnRlbnRzUmVhZHlGb3JEaXN0aWxsYXRpb24M. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Blockedon: 882937
Blockedon: -882937
Mergedinto: 882937
Status: Duplicate (was: Assigned)
Blockedon: 882937

Sign in to add a comment