Browser actions are laid out LTR and their animations are LTR even when the browser layout is RTL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b0fd02afc2107ba123774e0a464a43407a108cf commit 8b0fd02afc2107ba123774e0a464a43407a108cf Author: lgrey <lgrey@chromium.org> Date: Fri Jan 06 12:24:01 2017 [Mac] Flip toolbar in RTL Browser actions will be reordered in a future change. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2607533004 Cr-Commit-Position: refs/heads/master@{#441925} [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0eda8fc58bd6357bb5a18e4d977b98de988857a commit d0eda8fc58bd6357bb5a18e4d977b98de988857a Author: lgrey <lgrey@chromium.org> Date: Mon Jan 09 16:10:28 2017 Revert of [Mac] Flip toolbar in RTL (patchset #5 id:80001 of https://codereview.chromium.org/2607533004/ ) Reason for revert: Caused crbug.com/679249 Original issue's description: > [Mac] Flip toolbar in RTL > > Browser actions will be reordered in a future change. > > BUG= 648558 , 648563 , 673362 > > Review-Url: https://codereview.chromium.org/2607533004 > Cr-Commit-Position: refs/heads/master@{#441925} > Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf TBR=tapted@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2622613002 Cr-Commit-Position: refs/heads/master@{#442257} [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/882ccc67f27351913c6ae4384c1a79441e1becea commit 882ccc67f27351913c6ae4384c1a79441e1becea Author: lgrey <lgrey@chromium.org> Date: Thu Jan 12 20:32:21 2017 [Mac] Flip toolbar in RTL (reland) This was reverted due to crbug.com/679174 which is fixed by using the browser action container view's |animationEndFrame| instead of its frame when calculating the size of the location bar. Browser actions will be reordered in a future change. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2607533004 Cr-Commit-Position: refs/heads/master@{#441925} Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001) Review-Url: https://codereview.chromium.org/2631463004 Cr-Commit-Position: refs/heads/master@{#443345} [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f898b1b6c9fe4df63bed3150005f83c7b22601c commit 9f898b1b6c9fe4df63bed3150005f83c7b22601c Author: lgrey <lgrey@chromium.org> Date: Mon Feb 27 15:50:43 2017 [Mac] Reverse order of browser actions in RTL Dragging works correctly as well BUG= 648563 Review-Url: https://codereview.chromium.org/2718763002 Cr-Commit-Position: refs/heads/master@{#453222} [modify] https://crrev.com/9f898b1b6c9fe4df63bed3150005f83c7b22601c/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
This is not a localization bug. Can't confirm that it's still relevant to the current English UI.
Lgrey@,Could you please let us know the steps to test chis issue from TE end. Thanks in advance..!!
Enable chrome://flags#mac-rtl and either: - set your language to Arabic or Hebrew and reboot (or log out of macOS and back in) or - launch with -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES --force-ui-direction=rtl
Comment 1 by shrike@chromium.org
, Nov 15 2016Status: Assigned (was: Available)