New issue
Advanced search Search tips

Issue 648561 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

cocoa browser: bookmarks menus look wrong in RTL

Project Member Reported by ellyjo...@chromium.org, Sep 20 2016

Issue description

With Chrome in RTL mode, bookmark menus appear with their icons left-justified, their text right-justified, and folder expansion arrows also right-justified, so that they draw over the text. Also, submenus open to the right of their parent menu instead of the left.
 

Comment 1 by lgrey@chromium.org, Nov 15 2016

Owner: lgrey@chromium.org
Status: Started (was: Available)

Comment 2 by shrike@chromium.org, Nov 28 2016

Here's a screenshot showing ellipsis issues in RTL mode. I mentioned in https://codereview.chromium.org/2511973002/ that there are layout problems in LTR mode but I'm not seeing them now (before I was running with my default user-data-dir - this screenshot was taken using an empty user-data-dir).

This is Chromium 57.0.2925.0.

Screen Shot 2016-11-28 at 10.21.07 AM.png
32.2 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e85d0513cdbaeeff936cc30f1d73ae9887d1df43

commit e85d0513cdbaeeff936cc30f1d73ae9887d1df43
Author: lgrey <lgrey@chromium.org>
Date: Wed May 03 22:07:57 2017

[Mac] Reverse bookmark buttons and menus in RTL (take 2)

LTR image diffs show this as:
- Identical to HEAD in retina
- In non-retina, some bookmarks at the width limit show an additional character vs. HEAD. I think this is more true to the spec and is closer to Views (though it's hard to compare directly since views fades instead of cutting off with an ellipsis)

This is a semi-manual rebase of
https://codereview.chromium.org/2511973002/

BUG= 648561 ,  648560 

Review-Url: https://codereview.chromium.org/2845003003
Cr-Commit-Position: refs/heads/master@{#469157}

[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/gradient_button_cell.h
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/gradient_button_cell.mm
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/l10n_util.h
[modify] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/chrome/browser/ui/cocoa/l10n_util.mm

Comment 4 by ecacho@google.com, Jun 27 2017

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Started)
This is not a localization bug. Can't confirm that it's still relevant to the current English UI

Comment 5 by ajha@chromium.org, Jun 28 2017

Cc: ajha@chromium.org
Labels: Needs-Feedback
Status: Assigned (was: Unconfirmed)
lgrey@: Please confirm on how to enable Mac rtl behavior as mac-rtl flag doesn't have any effect.

Comment 6 by lgrey@chromium.org, Jun 28 2017

ajha@ along with enabling the MacRTL feature you need to either:
- set your language to Arabic or Hebrew and reboot (or log out of macOS and back in) or
- launch with -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES --force-ui-direction=rtl

Comment 7 by ajha@chromium.org, Jun 30 2017

Labels: -Needs-TestConfirmation
Thanks Igrey@ for the updated steps. This looks to be WAI as per the behavior mentioned in C#0. Attached is the screenshot of the same.

lgrey@: Could you please confirm if there is still WIP for this.


648561.png
43.7 KB View Download

Comment 8 by lgrey@chromium.org, Jun 30 2017

Not actively, but as a general rule, I'm not marking Proj-MacRTL bugs fixed until we're shipping them to at least some percentage of users (which we don't plan to do until everything is done.)
Status: Archived (was: Assigned)

Sign in to add a comment