New issue
Advanced search Search tips

Issue 648559 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

cocoa browser: tabstrip is not RTL-aware

Project Member Reported by ellyjo...@chromium.org, Sep 20 2016

Issue description

The tabstrip is still laid out LTR even when the browser is in RTL locales. There is partial support for RTL layout with --enable-features=ExperimentalMacRTL, but major functionality (tab dragging, rapid close) is broken under that flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe4bf0ef14bf8210c68afe04d027c3ea7e0fc638

commit fe4bf0ef14bf8210c68afe04d027c3ea7e0fc638
Author: lgrey <lgrey@chromium.org>
Date: Thu Oct 13 18:37:21 2016

Make new tab button animation RTL-aware

BUG= 648559 

Review-Url: https://codereview.chromium.org/2407413004
Cr-Commit-Position: refs/heads/master@{#425102}

[modify] https://crrev.com/fe4bf0ef14bf8210c68afe04d027c3ea7e0fc638/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c69e8b4dc28142dd4655e205f5ccd938569a00

commit 69c69e8b4dc28142dd4655e205f5ccd938569a00
Author: lgrey <lgrey@chromium.org>
Date: Tue Nov 15 00:22:32 2016

[Mac] Fix tab dragging in RTL

BUG= 648559 

Review-Url: https://codereview.chromium.org/2493273002
Cr-Commit-Position: refs/heads/master@{#432012}

[modify] https://crrev.com/69c69e8b4dc28142dd4655e205f5ccd938569a00/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Comment 5 by shrike@chromium.org, Nov 15 2016

Owner: lgrey@chromium.org
Status: Assigned (was: Available)

Comment 6 by lgrey@chromium.org, Nov 15 2016

Cc: lgrey@chromium.org
 Issue 651300  has been merged into this issue.

Comment 8 by lgrey@chromium.org, Nov 29 2016

Attaching a screenshot of the RTL tabstrip on 10.11 with https://codereview.chromium.org/2541583002/ applied

Screen Shot 2016-11-29 at 12.20.02 PM.png
18.5 KB View Download

Comment 9 by ecacho@google.com, Jun 27 2017

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Assigned)
This is not a localization bug. Can't confirm that it's still relevant to the current English UI.

Comment 10 by ajha@chromium.org, Jun 28 2017

Cc: ajha@chromium.org
Labels: Needs-Feedback
Status: Assigned (was: Unconfirmed)
mac-rtl flag doesn't have any effect as tested on Mac OS 10.12.5 on the latest canary version: 61.0.3143.0.

lgrey@: Could you please confirm if this is still WIP.
Status: Archived (was: Assigned)

Sign in to add a comment