Omnibox decorations are laid out LTR even when the browser is in RTL mode.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24cb108d6ed64df2a989b99c609193c6ab67393f commit 24cb108d6ed64df2a989b99c609193c6ab67393f Author: lgrey <lgrey@chromium.org> Date: Thu Dec 08 19:13:18 2016 [Mac] RTL-aware drawing and animation for the content settings decoration BUG= 648557 Review-Url: https://codereview.chromium.org/2564593002 Cr-Commit-Position: refs/heads/master@{#437301} [modify] https://crrev.com/24cb108d6ed64df2a989b99c609193c6ab67393f/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2706cca2d666501c5d1319798e3a7ec7add4ca1 commit c2706cca2d666501c5d1319798e3a7ec7add4ca1 Author: lgrey <lgrey@chromium.org> Date: Fri Dec 09 20:31:20 2016 [Mac] RTL-aware drawing for keyword hint decoration BUG= 648557 Review-Url: https://codereview.chromium.org/2559243002 Cr-Commit-Position: refs/heads/master@{#437626} [modify] https://crrev.com/c2706cca2d666501c5d1319798e3a7ec7add4ca1/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36c124b2f291fb5ccafab387f59d3b3b9948422f commit 36c124b2f291fb5ccafab387f59d3b3b9948422f Author: lgrey <lgrey@chromium.org> Date: Fri Dec 09 20:39:28 2016 [Mac] RTL-aware rendering for BubbleDecoration and SecurityStateBubbleDecoration This is almost the same exact code, so it might be worthwhile to find a way to abstract it out, but I think it's probably not in scope for this CL. BUG= 648557 Review-Url: https://codereview.chromium.org/2563593003 Cr-Commit-Position: refs/heads/master@{#437631} [modify] https://crrev.com/36c124b2f291fb5ccafab387f59d3b3b9948422f/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/36c124b2f291fb5ccafab387f59d3b3b9948422f/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8557f6fd655f9f0f62666721c7176d3d3c1e77f7 commit 8557f6fd655f9f0f62666721c7176d3d3c1e77f7 Author: lgrey <lgrey@chromium.org> Date: Tue Dec 20 15:31:11 2016 [Mac] RTL aware drawing for the bubble decoration hover background BUG= 648557 Review-Url: https://codereview.chromium.org/2586363002 Cr-Commit-Position: refs/heads/master@{#439808} [modify] https://crrev.com/8557f6fd655f9f0f62666721c7176d3d3c1e77f7/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdc6c66162e754b82e2d7f5db09767733d49005c commit fdc6c66162e754b82e2d7f5db09767733d49005c Author: lgrey <lgrey@chromium.org> Date: Wed Dec 21 20:56:13 2016 [Mac] Fix bubble anchors in RTL Previously, Bubble decoration and subclasses used slightly different code to calculate where the image *should* be drawn, and where it was drawn in practice. This change unites that code and removes code that compensated for the difference. The change in ContentSettingsBubble isn't RTL specific and fixes a general regression (content settings bubbles in Canary are anchored too far to the right.) BUG= 648557 Review-Url: https://codereview.chromium.org/2594543004 Cr-Commit-Position: refs/heads/master@{#440206} [modify] https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm [modify] https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm [modify] https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753efdea7319cbdca59df1e1d7b458c4eaa3c479 commit 753efdea7319cbdca59df1e1d7b458c4eaa3c479 Author: lgrey <lgrey@chromium.org> Date: Wed Dec 28 20:59:20 2016 [Mac] Reverse the omnibox in RTL BUG= 648554 , 648557 , 673362 Review-Url: https://codereview.chromium.org/2576563002 Cr-Commit-Position: refs/heads/master@{#440891} [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
Confirmed on Canary, filed crbug.com/678257 for bubble direction
Comment 1 by lgrey@chromium.org
, Oct 28 2016