cocoa browser: omnibox RTL is incomplete |
|||
Issue descriptionThe omnibox displays incomplete RTL behavior with -NSForceRightToLeftWritingDirection YES -AppleTextDirection YES --force-ui-direction=rtl: 1) The initial omnibox value is left-justified, not right-justified 2) Once you start typing, the text jumps to the right side of the omnibox 3) If you select a completion, or a completion is offered, the text jumps back to the left side, but the completion menu is still on the right side 4) If the "tab to search" decoration is visible, it is drawn over something else in the omnibox, making the text unreadable 5) Once you navigate, the omnibox text ends up on the left again
,
Dec 2 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f56da4755ccc370cd682cce472d4ba1c0781207 commit 4f56da4755ccc370cd682cce472d4ba1c0781207 Author: lgrey <lgrey@chromium.org> Date: Wed Dec 14 16:38:58 2016 There's a bunch of weird glitches right now that cause the text to flip to the left. AFAICT, these two changes fix all of them: 1) Set the alignment of the text field directly. 2) RFC 3987 requires us to set the writing direction of URLs to LTR so that we get שלום.com instead of moc.שלום. This appears to change the alignment of the string if it's not set explicitly. So: set it explicitly. BUG= 648554 , 673362 Review-Url: https://codereview.chromium.org/2555783002 Cr-Commit-Position: refs/heads/master@{#438529} [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753efdea7319cbdca59df1e1d7b458c4eaa3c479 commit 753efdea7319cbdca59df1e1d7b458c4eaa3c479 Author: lgrey <lgrey@chromium.org> Date: Wed Dec 28 20:59:20 2016 [Mac] Reverse the omnibox in RTL BUG= 648554 , 648557 , 673362 Review-Url: https://codereview.chromium.org/2576563002 Cr-Commit-Position: refs/heads/master@{#440891} [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Jan 4 2017
Confirmed on Canary |
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Nov 15 2016Status: Assigned (was: Available)