New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Underscore not visible

Reported by cornel.c...@gmail.com, Sep 20 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36

Steps to reproduce the problem:
1. Watch for a variable whose value contains an underscore(.g. '_0')
2. Note that the underscore is visible only inside the tooltip, when hovering the variable value

What is the expected behavior?
The underscores should be visible in the strings.

What went wrong?
The underscores are not visible in the strings.

Did this work before? Yes 

Chrome version: 53.0.2785.101  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0
 
one.PNG
6.3 KB View Download
two.PNG
8.6 KB View Download
Seems to be a margin problem. See how the square brackets are also trimmed(in two.PNG).
What is your zoom level?
How can I objectively determine the zoom level for dev tools?

Comment 4 by alph@chromium.org, Oct 10 2016

Owner: chowse@chromium.org
Status: Assigned (was: Unconfirmed)
Can repro.
On certain zoom levels the line-height of .watch-expression-title is not enough to fit the underscore.

Comment 5 by chowse@chromium.org, Feb 17 2017

Cc: chowse@chromium.org
Owner: alph@chromium.org
Provided this field is always one line (which I assume it is since it's text-overflow: ellipsis), you can compensate for this by increasing the line height or vertical padding around the field, then adding a negative margin to restore it to its original position.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe33e303b2618fb2c98e987a8c97fd58b5adeb2d

commit fe33e303b2618fb2c98e987a8c97fd58b5adeb2d
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Dec 14 21:59:53 2017

DevTools: tweak watches line height.

BUG= 648548 
NOTRY=true

Change-Id: If61eef633f510b192dd7587acec5b97709e60f50
Reviewed-on: https://chromium-review.googlesource.com/826127
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524197}
[modify] https://crrev.com/fe33e303b2618fb2c98e987a8c97fd58b5adeb2d/third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css

Comment 7 by alph@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment