New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648547 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scrollbar is seen in chrome://md-settings/help on reloading the page.

Project Member Reported by bj00129...@techmahindra.com, Sep 20 2016

Issue description

Version: 55.0.2866.0 Dev
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome>>Navigate to chrome://md-settings/help>>Click on reload icon and observe unwanted vertical scrollbar

Expected: No such scrollbar should be seen on reloading.
Actual: Instead unwanted vertical scrollbar is seen.

This is Regression issue broken in M-55.Will soon update bisect info.

Manual bisect info:
Good build:55.0.2865.0 Dev
Bad build:55.0.2866.0 Dev

Attaching screen-cast for reference.
 
Actual_Unwantedscrollbar_help.ogv
1.3 MB View Download
Labels: Needs-Bisect OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.11.6 using chrome version 55.0.2866.0 
Labels: -Needs-Bisect hasbisect-per-revision
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2862.0 (Revision: 419063).
Bad build: 55.0.2863.0 (Revision: 419330).

You are probably looking for a change made after 419066 (known good), but no later than 419067 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/56eaf1eac112390d863b0d738ad97d05730d36e2..cd626f11b0ddb8fc655ac2fd808ca3930e3e29cf

From the CL above, assigning the issue to the concern owner --
@xiaochengh -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Correction in comment #0:

Manual bisect info:
Good build:55.0.2862.0 Dev
Bad build:55.0.2863.0 Dev
After locally reverting r419067 the issue no longer reproduces.

I'm going to revert r419067.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/593d84c9016da731e62991eec28d998104b121da

commit 593d84c9016da731e62991eec28d998104b121da
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Sep 21 10:44:07 2016

Revert "Document::haveImportsLoaded() should return true when ignoring pending sheets"

This is a manual revert of commit cd626f11b0ddb8fc655ac2fd808ca3930e3e29cf
for causing  crbug.com/648547 .

It also marks editing/selection/modify_move/move_backward_line_import_crash.html
as crashing, because this layout test is a repro case of  crbug.com/646323 .

Original issue's description:
> Document::haveImportsLoaded() should return true when ignoring pending sheets
>
> BUG= 646323 
> TESTS=webkit_unit_tests DocumentLoadingRenderingTest.ShouldNotPerformRepeatedLayoutWithPendingImport DocumentLoadingRenderingTest.ShouldClearPlaceholderStyleWhenIgnoringPendingStylesheet
>
> Committed: https://crrev.com/cd626f11b0ddb8fc655ac2fd808ca3930e3e29cf
> Cr-Commit-Position: refs/heads/master@{#419067}

BUG= 648547 , 646323 
TBR=esprehn@chromium.org,rune@chromium.org

Review-Url: https://codereview.chromium.org/2353243002
Cr-Commit-Position: refs/heads/master@{#420023}

[modify] https://crrev.com/593d84c9016da731e62991eec28d998104b121da/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/593d84c9016da731e62991eec28d998104b121da/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/593d84c9016da731e62991eec28d998104b121da/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e3d20e14e91f3999e3ec92fc9f706f9b29d21b

commit 62e3d20e14e91f3999e3ec92fc9f706f9b29d21b
Author: fs <fs@opera.com>
Date: Wed Sep 21 13:48:04 2016

Widen Mac expectations for move_backward_line_import_crash.html

editing/selection/modify_move/move_backward_line_import_crash.html
appears to also Crash on Mac Debug.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/4772

TBR=xiaochengh@chromium.org
BUG= 648547 , 646323 
NOTRY=true

Review-Url: https://codereview.chromium.org/2360593002
Cr-Commit-Position: refs/heads/master@{#420040}

[modify] https://crrev.com/62e3d20e14e91f3999e3ec92fc9f706f9b29d21b/third_party/WebKit/LayoutTests/TestExpectations

r419067 is already reverted. I can no longer repro with Canary 55.0.2868.0.

Could anyone from test team help me verify if the issue is fixed?
Issue seems to be fixed as this issue no longer re-pro on Ubuntu 14.04 with Latest chrome version Dev #55.0.2868.0.
648547.ogv
831 KB View Download

Comment 9 by dpa...@chromium.org, Sep 22 2016

Status: Fixed (was: Assigned)
Can't repro either anymore.

Sign in to add a comment