New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648520 link

Starred by 2 users
Status: Verified
Owner:
varkha@chromium.org
Closed: Sep 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
pucchakayala@chromium.org
█ brajkumar@chromium.org
songsuk@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Window header of full screen windows are seen missing in overview mode

Project Member Reported by sc00335...@techmahindra.com, Sep 20 2016 
Version : 55.0.2862.3
Platform: 8818.0.0
Devices : Peppy,Daisy,Blaze,Mighty
OS      : Chrome OS

What steps will reproduce the problem?
(1) Sign in to user >> Open any two windows >> Enter full screen in any of window [Say Window1] >> Hit []] to enter overview mode and observe for header of full screen window

Expected: Name of full screen window should be seen even in overview mode.
Actual: Instead header is seen missing for full screened window in overview mode.

This is a regression issue as same is working fine in 53.0.2785.123/8530.87.0 stable channel daisy

@Varkha: Please confirm the issue.
Expected_window header.png
521 KB View Download
Actual_header.png
819 KB View Download

Comment 1 by sc00335...@techmahindra.com, Sep 20 2016 

When more number of windows are there some misplacement of header is also seen.

Attaching screenshot for reference
Actual_!.png
793 KB View Download

Comment 2 by kavvaru@chromium.org, Sep 20 2016

Cc: songsuk@chromium.org pucchakayala@chromium.org
Able to reproduce the issue on Blaze using chrome version 55.0.2862.3/8818.0.0

Comment 3 by varkha@chromium.org, Sep 20 2016 

Is this the case in M-54 beta as well?

Comment 4 by sc00335...@techmahindra.com, Sep 20 2016 

This works fine in M54 beta i.e;54.0.02840.33/8743.35.0 beta channel blaze.

No window header is missing when in fullscreen mode.

Comment 5 by varkha@chromium.org, Sep 22 2016

Status: Started (was: Assigned)
Draft at https://codereview.chromium.org/2358833003/.

Comment 6 by varkha@chromium.org, Sep 22 2016 

Regression introduced in https://codereview.chromium.org/2336673002/ so M-54 is indeed safe and this was only recently broken in M-55.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a241953aa9d0ecd5375771e634f8638e004a9961

commit a241953aa9d0ecd5375771e634f8638e004a9961
Author: varkha <varkha@chromium.org>
Date: Thu Sep 22 15:15:53 2016

[ash-md] Corrects initial positioning of the overview headers

This regression was introduced when order of initialization was changed
in https://codereview.chromium.org/2336673002/ . This CL restores the
order.

BUG= 648520 

Review-Url: https://codereview.chromium.org/2358833003
Cr-Commit-Position: refs/heads/master@{#420346}

[modify] https://crrev.com/a241953aa9d0ecd5375771e634f8638e004a9961/ash/common/wm/overview/window_selector_item.cc

Comment 8 by varkha@chromium.org, Sep 22 2016

Status: Fixed (was: Started)

Comment 9 by rookrishna@chromium.org, Oct 18 2016

Status: Verified (was: Fixed)
Verified 55.0.2883.17/8872.15.0
►

Sign in to add a comment