MD Settings: policy indicators for Chrome OS non-pref settings |
|||||||||||
Issue descriptionCrOS needs policy indicators that are not dependent on prefs, e.g. to inform a secondary user why they can't change the UI language in a multi-user session. <cr-policy-pref-indicator> has a hack to enable controlled-by indicators, but it's broken (because the indicatorType is read-only): https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js?type=cs&ssfr=1&sq=package:chromium&l=23-27
,
Sep 23 2016
@dbeam, can you look into this with your other policy indicator work? michaelpg and I worked on the changes to the Settings page if you have any questions. PRD is here: https://docs.google.com/document/d/1G09Mql1TtVFA4qhb7hlt4u2crBv6_fhrZMf40Yo--lc/edit
,
Sep 23 2016
,
Oct 14 2016
,
Nov 22 2016
,
Dec 8 2016
,
Dec 9 2016
Tom: Is there a mock for how the indicator at the top of Settings for a secondary user should look? ("Some settings belonging to owner@gmail.com are being shared with you..."
In the meanwhile I'll create cr-policy-owner-indicator and track down the (few I think) places where we currently have an indicator not tied to a pref.
,
Dec 9 2016
I only found two places where we currently have special non pref indicators for secondary users: 1. Language: Next to 'Display Chrome OS in this language' ** NOTE: This is a dropdown option in the vertical ... menu in the new UI. The option is currently omitted for secondary users. 2. Internet: Next to 'Internet connection' Tom / Alan, any thoughts on how we should address these in MD Settings? 1. I think we can just omit this, but am open to suggestions. 2. The current behavior for Internet is kind of strange. The secondary user can see the UI, but it doesn't do anything. I would like to change this so that the functionality matches that of the status area (you can change networks, disconnect, or disable/enable), but hide any configuration UI (which won't work). Does that sound reasonable? In that case it would make sense to show a message in the configuration (details) page instead of the details. I can whip something together and attach a screenshot if you like I'll put something together
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8db79167a77b48b6eb30d2631a1e06fe83cc25e0 commit 8db79167a77b48b6eb30d2631a1e06fe83cc25e0 Author: stevenjb <stevenjb@chromium.org> Date: Fri Dec 09 18:13:07 2016 MD Settings: cr-policy-pref-indicator: Eliminate controllingUser This property is unused and unnecessary. BUG= 648498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2555373006 Cr-Commit-Position: refs/heads/master@{#437587} [modify] https://crrev.com/8db79167a77b48b6eb30d2631a1e06fe83cc25e0/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html [modify] https://crrev.com/8db79167a77b48b6eb30d2631a1e06fe83cc25e0/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
,
Dec 12 2016
My current plan is to fix Internet and call this done. If we decide we want to add something for Language we can re-open this or file something new.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9 commit bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9 Author: stevenjb <stevenjb@chromium.org> Date: Wed Dec 14 01:25:50 2016 MD Settings: Internet: Only show detailed info for primary user. BUG= 648498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2568593002 Cr-Commit-Position: refs/heads/master@{#438379} [modify] https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9/chrome/app/settings_strings.grdp [modify] https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/bfeca7cd9b6e45c1e00cb86dd44eac76f2e082b9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Dec 14 2016
,
Mar 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891 commit 67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891 Author: michaelpg <michaelpg@chromium.org> Date: Sat Mar 11 02:20:07 2017 cr-policy-indicator element for non-preference-based indicators BUG= 648498 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2744923002 Cr-Commit-Position: refs/heads/master@{#456259} [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/browser/resources/settings/date_time_page/compiled_resources2.gyp [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/browser/resources/settings/date_time_page/date_time_page.html [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/browser/resources/settings/date_time_page/date_time_page.js [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/test/data/webui/cr_elements/cr_policy_indicator_tests.js [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/chrome/test/data/webui/settings/date_time_page_tests.js [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements/network/cr_network_list_item.html [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements/policy/README.md [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements/policy/compiled_resources2.gyp [add] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html [add] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements/policy/cr_policy_indicator.js [modify] https://crrev.com/67c8ffe8dc73fb95bb8fcfe63fd5e1d2c34ee891/ui/webui/resources/cr_elements_resources.grdp
,
May 15 2017
9554.0.0, 60.0.3100.0. Verified that detailed network info is shown only for primary user |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by abodenha@chromium.org
, Sep 20 2016Status: Assigned (was: Untriaged)